Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Translate the course to other language #16

Closed
2 tasks done
antonio-pedro99 opened this issue Jul 24, 2023 · 24 comments 路 Fixed by #38 or #42 路 May be fixed by #35
Closed
2 tasks done

Feature: Translate the course to other language #16

antonio-pedro99 opened this issue Jul 24, 2023 · 24 comments 路 Fixed by #38 or #42 路 May be fixed by #35
Assignees
Labels

Comments

@antonio-pedro99
Copy link
Contributor

Type of feature

馃摑 Documentation

Current behavior

Hi, it is a perfect course for beginners and I would like to introduce it to my newborn open-source community in Angola(github.com/angolaosc), but the biggest part of my community do not speak or understand English.

Suggested solution

It would be perfect if we can have a translation of this course.

I will be available to contribute translating most of the part of this course into Portuguese and encourage people from my community to contribute too.

Additional context

idiom

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie
Copy link
Member

bdougie commented Aug 11, 2023

I'd love to see this course get translated. I used to run workshops when I worked at GitHub and the platform is able to handle translations based on the language set by the browser using the language codes in the README.

For example the pattern would be the following

  1. create the folder for the language i.e. portugese-brasil
  2. suffix pt-br to the files.

see the example here in Korean. cc @BekahHW

https://github.com/tiimgreen/github-cheat-sheet/blob/master/README.ko.md

also pt-br

https://github.com/github-craftwork/python-brasil/blob/master/README-pt-br.md

@CBID2
Copy link
Contributor

CBID2 commented Aug 11, 2023

I like this idea too @bdougie. If @BekahHW's ok with this, I'd like to raise a PR for it.

@antonio-pedro99
Copy link
Contributor Author

@bdougie nice you liked the idea.
@CBID2 is planning to open a PR for that, I am in to contribute with the Portuguese translation

@CBID2
Copy link
Contributor

CBID2 commented Aug 11, 2023

@bdougie nice you liked the idea.

@CBID2 is planning to open a PR for that, I am in to contribute with the Portuguese translation

If I get the ok from @BekahHW of course

@antonio-pedro99
Copy link
Contributor Author

@bdougie nice you liked the idea.
@CBID2 is planning to open a PR for that, I am in to contribute with the Portuguese translation

If I get the ok from @BekahHW of course

LGTM

@BekahHW
Copy link
Member

BekahHW commented Aug 11, 2023

@CBID2 Sounds great!

@antonio-pedro99
Copy link
Contributor Author

@CBID2 Sounds great!

馃憣馃憣馃憣

@antonio-pedro99
Copy link
Contributor Author

@CBID2 what's on your mind for the first PR?

@CBID2
Copy link
Contributor

CBID2 commented Aug 11, 2023

@CBID2 what's on your mind for the first PR?

Good question @antonio-pedro99. I'm thinking of this:

  1. Creating the file structure for the bilingual Markdown files based on the links @bdougie provided.
  2. Create a Draft PR, so you can add the Portuguese version of the files
    How does that sound?

@antonio-pedro99
Copy link
Contributor Author

@CBID2 We need to think how to organize the repo to be able to support multiples languages. If we just translate page by page each .md file in the root, we will have lot of files and the navigation through the repository will be hard.

I am not sure docsify supports it, but my initial thought is to create a folder for each translation. Something like

pt-br/
.... 01-Introdu莽膩o.md
.... 02-Outra Sess茫o.md
....
.... 09-Gloss谩rio.md

What do you think?

@antonio-pedro99
Copy link
Contributor Author

antonio-pedro99 commented Aug 11, 2023

I like the idea.

@CBID2 what's on your mind for the first PR?

Good question @antonio-pedro99. I'm thinking of this:

  1. Creating the file structure for the bilingual Markdown files based on the links @bdougie provided.
  2. Create a Draft PR, so you can add the Portuguese version of the files
    How does that sound?

Yes, it is very similar to what I wrote recently

@CBID2
Copy link
Contributor

CBID2 commented Aug 11, 2023

@CBID2 We need to think how to organize the repo to be able to support multiples languages. If we just translate page by page each .md file in the root, we will have lot of files and the navigation through the repository will be hard.

I am not sure docsify supports it, but my initial thought is to create a folder for each translation. Something like

pt-br/

.... 01-Introdu莽膩o.md

.... 02-Outra Sess茫o.md

....

.... 09-Gloss谩rio.md

What do you think?

I like that

@CBID2
Copy link
Contributor

CBID2 commented Aug 11, 2023

I'm going to start the draft PR tomorrow if you don't mind @antonio-pedro99

@antonio-pedro99
Copy link
Contributor Author

Please take your time

@CBID2 CBID2 added 馃崟 enhancement New feature or request and removed 馃憖 needs triage labels Aug 12, 2023
@CBID2 CBID2 mentioned this issue Aug 12, 2023
19 tasks
@CBID2
Copy link
Contributor

CBID2 commented Aug 12, 2023

Please take your time

Hey @antonio-pedro99! :) I started the pull request for this issue. I placed it in draft mode so you can start adding the translated files.

@antonio-pedro99
Copy link
Contributor Author

Please take your time

Hey @antonio-pedro99! :) I started the pull request for this issue. I placed it in draft mode so you can start adding the translated files.

Hi @CBID2, thanks for that. I am on it.

@antonio-pedro99
Copy link
Contributor Author

@bdougie @CBID2 @BekahHW should we create a milestone for this issue? We are not going to translate to Portuguese only.
Tell me what you think.

@CBID2
Copy link
Contributor

CBID2 commented Aug 12, 2023

@bdougie @CBID2 @BekahHW should we create a milestone for this issue? We are not going to translate to Portuguese only.

Tell me what you think.

I agree @antonio-pedro99. It's a significant thing

@geoffreylgv
Copy link
Contributor

Hi @CBID2 @bdougie @BekahHW @antonio-pedro99
I would like to contribute to the intro to open source in French version.

Since the translation folder is in draft, can I do it,
or a maintainer should create fr-fr folder for me,
or I will wait for the PR+merge, to start ?

@antonio-pedro99
Copy link
Contributor Author

Hi @CBID2 @bdougie @BekahHW @antonio-pedro99 I would like to contribute to the intro to open source in French version.

Since the translation folder is in draft, can I do it, or a maintainer should create fr-fr folder for me, or I will wait for the PR+merge, to start ?

Hey @geoffreylgv, sounds interesting.
I am fine with that.

Let's wait what others will say.

@CBID2
Copy link
Contributor

CBID2 commented Aug 19, 2023

Hi @CBID2 @bdougie @BekahHW @antonio-pedro99

I would like to contribute to the intro to open source in French version.

Since the translation folder is in draft, can I do it,

or a maintainer should create fr-fr folder for me,

or I will wait for the PR+merge, to start ?

I was just about to do it in French too @geoffreylgv. 馃槉 I'll set up the folders and files. From there, you can translate the rest.

@geoffreylgv
Copy link
Contributor

Ok perfect, thank you

@CBID2 CBID2 mentioned this issue Aug 20, 2023
19 tasks
@CBID2
Copy link
Contributor

CBID2 commented Aug 20, 2023

Ok perfect, thank you

Hey @geoffreylgv! :) I just sent you an invite to my fork, check your email to accept the invite. From there, go to #38 in the Pull Request Tabs

@CBID2
Copy link
Contributor

CBID2 commented Sep 1, 2023

Hey @antonio-pedro99. Here's the PR for the sidebar @geoffreylgv made: #42

@CBID2 CBID2 reopened this Sep 8, 2023
@CBID2 CBID2 reopened this Dec 20, 2023
@CBID2 CBID2 closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment