Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Redirect opensauced.pizza/username to /user/username #124

Closed
1 of 2 tasks
bdougie opened this issue May 9, 2023 · 8 comments
Closed
1 of 2 tasks

Feature: Redirect opensauced.pizza/username to /user/username #124

bdougie opened this issue May 9, 2023 · 8 comments

Comments

@bdougie
Copy link
Member

bdougie commented May 9, 2023

Type of feature

馃崟 Feature

Current behavior

Working on social cards and it would be nice to redirect these urls.

Group 1 (5)

Suggested solution

Add a redirect in Netlify

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie transferred this issue from open-sauced/app May 9, 2023
@shamimbinnur
Copy link
Contributor

@bdougie Did you mean https://opensauced.pizza/username to https://insights.opensauced.pizza/user/username?

@bdougie
Copy link
Member Author

bdougie commented May 21, 2023

@bdougie Did you mean https://opensauced.pizza/username to https://insights.opensauced.pizza/user/username?

Yes. This will most likely need an edge function to quickly check if the user exist in the API.

Open to other suggestions.

@shamimbinnur
Copy link
Contributor

@bdougie Did you mean https://opensauced.pizza/username to https://insights.opensauced.pizza/user/username?

Yes. This will most likely need an edge function to quickly check if the user exist in the API.

Open to other suggestions.

@bdougie Where would the user be redirected if the user doesn't exist?

Since we are redirecting users to the insight, shouldn't the insight app handle the rest?

@bdougie
Copy link
Member Author

bdougie commented May 21, 2023

Since we are redirecting users to the insight, shouldn't the insight app handle the rest?

Correct ideally the insights app would have a 404. Today the page displays with errored data if not found.

@bdougie
Copy link
Member Author

bdougie commented May 21, 2023

Might be better suited for a URL shortener.

@shamimbinnur
Copy link
Contributor

@bdougie If we use the "/username" path we will be required to check our existing pages ('/blog', '/teams) and add some logic to treat these as reserved paths. And this has to be refactored every time we add a new route for pages.

But if we use "/u/username" we will not be required the checking.

Which path should we go for?

@bdougie
Copy link
Member Author

bdougie commented May 21, 2023

Let's go with /u

@shamimbinnur
Copy link
Contributor

@bdougie This issue has been fixed and addressed in #128

@bdougie bdougie closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants