Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add user redirect & Update @react/types #128

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

shamimbinnur
Copy link
Contributor

@shamimbinnur shamimbinnur commented May 22, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds the feature to redirect OpenSauced users to the Insight app.
E.g: opensauced.pizza/u/bdougie to https://insights.opensauced.pizza/user/bdougie

Suddenly there was an error coming up with an older version of @react/types. So, I had to update it to version 18 and do some code refactoring for type checking.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented May 22, 2023

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit aa04c12
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/646cd8936c1b620008eed617
😎 Deploy Preview https://deploy-preview-128--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shamimbinnur shamimbinnur changed the title feat: Add user redirect & Updated @react/types feat: Add user redirect & Update @react/types May 22, 2023
@shamimbinnur shamimbinnur marked this pull request as ready for review May 22, 2023 11:44
@shamimbinnur shamimbinnur requested a review from bdougie May 22, 2023 11:44
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT works!

@bdougie bdougie merged commit 423e73f into open-sauced:main Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants