Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: make changelog subtext accessible #198

Open
2 tasks done
BekahHW opened this issue Feb 5, 2024 · 3 comments
Open
2 tasks done

Bug: make changelog subtext accessible #198

BekahHW opened this issue Feb 5, 2024 · 3 comments
Assignees
Labels
a11y 🐛 bug Something isn't working

Comments

@BekahHW
Copy link
Member

BekahHW commented Feb 5, 2024

Describe the bug

On the changelog pages, it appears that the text next to bullet points is inaccessible. We need to make this a lighter color.

image

Steps to reproduce

Go to: https://opensauced.pizza/changelog/add-explainer-tootlip-to-cards-on-list-pages

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@BekahHW BekahHW added 🐛 bug Something isn't working 👀 needs triage and removed 👀 needs triage labels Feb 5, 2024
@dev-phantom
Copy link
Contributor

.take

Copy link

Thanks for taking this on! If you have not already, join the conversation in our Discord

@nickytonline
Copy link
Member

nickytonline commented Feb 24, 2024

To fix this, add the CSS class prose-ul:text-textPrimary to this <ReactMarkdown /> component.

<ReactMarkdown
className="mx-auto mb-24 leading-loose prose prose-xl prose-headings:text-textPrimary prose-p:text-textPrimary prose-img:mx-auto prose-img:rounded-md
prose-img:border-4 prose-img:border-brandOrange prose-img:bg-gradient-to-tr prose-img:from-[#ED5432] prose-img:via-[#EDA232] prose-img:to-[#ED5432] prose-img:drop-shadow-[0_0_4px_#ED5432]"
>

I'm not sure how all the typography is set up in this project as the base color appears to be really dark for a dark background, but that can be for another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants