Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 #19

Merged
merged 6 commits into from
May 17, 2022
Merged

V3 #19

merged 6 commits into from
May 17, 2022

Conversation

shamimbinnur
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR [adds/removes/fixes/replaces] the [feature/bug/etc].

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented May 16, 2022

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit ec090c0
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/6283864dcfdda80008493a83
😎 Deploy Preview https://deploy-preview-19--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shamimbinnur shamimbinnur marked this pull request as ready for review May 16, 2022 14:02
@bdougie
Copy link
Member

bdougie commented May 16, 2022

Thanks for putting this up @shamimbinnur.

Only two things and I think this is done.

  1. Can we add a similar transparent border to the feature copy on the page
  2. Can we add the Footer to the feature pages.

Adding a transparent background will make this more ledge-able.

Screen Shot 2022-05-16 at 10 50 19 AM

This was a great solution
Screen Shot 2022-05-16 at 10 53 25 AM

@shamimbinnur
Copy link
Contributor Author

Thanks for putting this up @shamimbinnur.

Only two things and I think this is done.

  1. Can we add a similar transparent border to the feature copy on the page
  2. Can we add the Footer to the feature pages.

Adding a transparent background will make this more ledge-able.

Screen Shot 2022-05-16 at 10 50 19 AM

This was a great solution Screen Shot 2022-05-16 at 10 53 25 AM

@bdougie can you open an issue for this?

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for turning this around.

@bdougie bdougie merged commit 2ea4979 into beta May 17, 2022
bdougie pushed a commit that referenced this pull request May 18, 2022
* Added vertical icon next to feature title

* Added vertical icon next to feature title

* transparent background for logos - #13

* Youtube video url embedding #15

* Transparent background on feature page #20

* Footer added on feature page #20
bdougie added a commit that referenced this pull request May 18, 2022
* new branch test

* GitHub mockup

* GithubMock & Calender Design

* Feature section

* Testimonial Section

* Testimonial completed

* fixed props kewy

* Connected sanity to GitHub mock & GitHub calender

* Fixed responsive issues on calender section & added border, callback on logos

* Added 'Projects link' and connected to Sanity

* Connected feature section with Sanity

* Feature page-backend

* Feature page front-end added

* Fixed responsive issues on feature-title

* Testimonial section connected to sanity

* added alt image

* Added 'Visit project' CTA Button

* added secondary button variant

* Issue no #6 has been resolved

* Fixed the issue no #5

* added back button and 'start now' CTA buttin

* removed a tag

* New color scheme - issue no #9

* Added footer

* Footer connection with sanity

* Removed padding

* Feature screen updates - Added Nav and Drip, Changed layout

* feat: link the image in the header (#16)

* link the image

* pointer

* V3 (#19)

* Added vertical icon next to feature title

* Added vertical icon next to feature title

* transparent background for logos - #13

* Youtube video url embedding #15

* Transparent background on feature page #20

* Footer added on feature page #20

Co-authored-by: shamimbinnur <sbnsbn00@gmail.com>
Co-authored-by: Shamim Bin Nur <48399373+shamimbinnur@users.noreply.github.com>
bdougie added a commit that referenced this pull request May 18, 2022
* new branch test

* GitHub mockup

* GithubMock & Calender Design

* Feature section

* Testimonial Section

* Testimonial completed

* fixed props kewy

* Connected sanity to GitHub mock & GitHub calender

* Fixed responsive issues on calender section & added border, callback on logos

* Added 'Projects link' and connected to Sanity

* Connected feature section with Sanity

* Feature page-backend

* Feature page front-end added

* Fixed responsive issues on feature-title

* Testimonial section connected to sanity

* added alt image

* Added 'Visit project' CTA Button

* added secondary button variant

* Issue no #6 has been resolved

* Fixed the issue no #5

* added back button and 'start now' CTA buttin

* removed a tag

* New color scheme - issue no #9

* Added footer

* Footer connection with sanity

* Removed padding

* Feature screen updates - Added Nav and Drip, Changed layout

* V3 (#19)

* Added vertical icon next to feature title

* Added vertical icon next to feature title

* transparent background for logos - #13

* Youtube video url embedding #15

* Transparent background on feature page #20

* Footer added on feature page #20

* V3 fast forward from main (#19) (#22)

* new branch test

* GitHub mockup

* GithubMock & Calender Design

* Feature section

* Testimonial Section

* Testimonial completed

* fixed props kewy

* Connected sanity to GitHub mock & GitHub calender

* Fixed responsive issues on calender section & added border, callback on logos

* Added 'Projects link' and connected to Sanity

* Connected feature section with Sanity

* Feature page-backend

* Feature page front-end added

* Fixed responsive issues on feature-title

* Testimonial section connected to sanity

* added alt image

* Added 'Visit project' CTA Button

* added secondary button variant

* Issue no #6 has been resolved

* Fixed the issue no #5

* added back button and 'start now' CTA buttin

* removed a tag

* New color scheme - issue no #9

* Added footer

* Footer connection with sanity

* Removed padding

* Feature screen updates - Added Nav and Drip, Changed layout

* feat: link the image in the header (#16)

* link the image

* pointer

* V3 (#19)

* Added vertical icon next to feature title

* Added vertical icon next to feature title

* transparent background for logos - #13

* Youtube video url embedding #15

* Transparent background on feature page #20

* Footer added on feature page #20

Co-authored-by: shamimbinnur <sbnsbn00@gmail.com>
Co-authored-by: Shamim Bin Nur <48399373+shamimbinnur@users.noreply.github.com>

Co-authored-by: shamimbinnur <sbnsbn00@gmail.com>
Co-authored-by: Shamim Bin Nur <48399373+shamimbinnur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants