Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Commit

Permalink
fix: add note about pr validation (#861)
Browse files Browse the repository at this point in the history
* add note about pr validation

* Update PULL_REQUEST_TEMPLATE.md

* fix unrelated 301 test
  • Loading branch information
bdougie committed Oct 24, 2020
1 parent e045365 commit 5cb383d
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
## Added to documentation?

- [ ] 馃摐 readme
- [ ] 馃摐 contributing.md
- [ ] 馃檯 no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?
Expand Down
14 changes: 14 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,20 @@ $ npm run test

*note for maintainers: All pull requests need a label to assist automation. See the [template](https://github.com/open-sauced/open-sauced/blob/HEAD/.github/release-drafter.yml) to guide which labels to use.*

### PR Validation
Examples for valid PR titles:

- fix: Correct typo.
- feat: Add support for Node 12.
- refactor!: Drop support for Node 6.

_Note that since PR titles only have a single line, you have to use the ! syntax for breaking changes._

See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for more examples.

### Work in progress
Github has support for draft pull requests, which will disable the merge button until the PR is marked as ready for merge.

## Issues

If you plan to contribute a change based on an open issue, please assign yourself by commenting on the following word `.take`. Issues that are not assigned are assumed open, and to avoid conflicts, please assign yourself before beginning work on any issues.
Expand Down
4 changes: 2 additions & 2 deletions src/lib/repoStatusCode.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ describe("Test: repoStatusCode()", () => {
expect(result).toBe(404);
});

test("bdougie/open-sauced should return 301", async() => {
test("bdougie/open-sauced should return 200", async() => {
const repoUrl = "bdougie/open-sauced";
const result = await repoStatusCode(repoUrl);
expect(result).toBe(301);
expect(result).toBe(200);
});
});

0 comments on commit 5cb383d

Please sign in to comment.