ci: improve workflow reusability across repositories (#1295)

open-sauced · Nov 5, 2021 · 802d9af · 802d9af
1 parent e16dd91
commit 802d9af
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 33 deletions.
diff --git a/.github/workflows/compliance.yml b/.github/workflows/compliance.yml
@@ -31,6 +31,7 @@ jobs:
           protected-branch-auto-close: false
           watch-files: |
             package.json
+            package-lock.json
             npm-shrinkwrap.json
           body-comment: >
             ## Issue Reference
@@ -49,11 +50,11 @@ jobs:
             [Contributing Guide](https://docs.opensauced.pizza/contributing/getting-started/). 
             We would suggest that you close this PR and implement your changes as 
             described in our Contributing Guide and open a new pull request.
+
   welcome:
     runs-on: ubuntu-latest
     needs: semantics
     if: github.event.action == 'opened'
-
     steps:
       - uses: actions/first-interaction@v1
         with:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -64,7 +64,7 @@ jobs:
         uses: actions/cache@v2
         with:
           path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/npm-shrinkwrap.json') }}
+          key: ${{ runner.os }}-node-${{ hashFiles('**/npm-shrinkwrap.json', '**/package-lock.json') }}
           restore-keys: |
             ${{ runner.os }}-node-
 
@@ -92,35 +92,6 @@ jobs:
           name: build
           path: build
 
-  lint:
-    name: Code standards
-    runs-on: ubuntu-latest
-    steps:
-      - name: "☁️ checkout repository"
-        uses: actions/checkout@v2
-
-      - name: "🔧 setup node"
-        uses: actions/setup-node@v2.1.5
-        with:
-          node-version: 16
-
-      - name: "🔧 setup cache"
-        uses: actions/cache@v2
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/npm-shrinkwrap.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
-
-      - name: "🔧 install npm@latest"
-        run: npm i -g npm@latest
-
-      - name: "📦 install dependencies"
-        run: npm ci
-
-      - name: "🔍 lint code"
-        run: npm run lint
-
   release:
     environment:
       name: production
@@ -129,7 +100,6 @@ jobs:
     needs:
       - docker
       - build
-      - lint
     runs-on: ubuntu-latest
     steps:
       - name: "☁️ checkout repository"
@@ -146,7 +116,7 @@ jobs:
         uses: actions/cache@v2
         with:
           path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/npm-shrinkwrap.json') }}
+          key: ${{ runner.os }}-node-${{ hashFiles('**/npm-shrinkwrap.json', '**/package-lock.json') }}
           restore-keys: |
             ${{ runner.os }}-node-