-
-
Notifications
You must be signed in to change notification settings - Fork 909
Bug: When adding brob/plug11ty.com "not valid" error #1451
Comments
I haven't reproduced yet, but here is the code path I suspect is responsible: Repo Form checking validity:
Validity Checker catching Line 5 in 4a26b94
From there, I haven't validated, but I believe the intention would be for us to consider this a "relative URL". |
Needs a fix for sure :D |
my gut tells me that this would be a sufficient check: const isRelativeUrl = !(url.substr(0,7) === 'http://' || url.substr(0,8) === 'https://'); The upsides to this would be:
Test suite would need adjustment too. |
Marking this as a good first issue - I think there's enough context to work with. |
the RFC itself is terrible, the function could use more regex to properly check for |
For what it's worth, this repo is flagged as invalid, for similar reasons: |
I want to work on this issue, please assign me |
Please review the CONTIBUTING.md for info on how to assign yourself to the issue. |
.take |
Thanks for taking this on! If you have not already, join the conversation in our Discord |
@mtfoley my test cases are not getting cleared. I am not getting what changes I need to do in https://github.com/open-sauced/open-sauced/blob/4a26b94eaa1a1094ee0dd0d7ca76ead50da2acc4/src/tests/util.test.js |
Hey, I don't see you having forked the open-sauced repo, once you do, you can apply the fixes discussed above. There is nothing you need to do to the unit test, it's the code that this issue requires fixing. If that is not the case IE you are not looking to contribute, let us know and we will assign to someone else :D |
I made a PR |
🎉 This issue has been resolved in version 0.52.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the bug
When adding a repository from my synced GitHub account, I get the message "Invalid GitHub repository"
Steps to reproduce
owner/repo
field type brob/plug11ty.com (corresponds to this repo)Affected services
opensauced.pizza
Platforms
Desktop
Browsers
Chrome
Environment
Production
Additional context
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: