Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Bug: Welcome action is broken and does not comment on PRs when opened #810

Closed
bdougie opened this issue Aug 21, 2020 · 1 comment · Fixed by #811
Closed

Bug: Welcome action is broken and does not comment on PRs when opened #810

bdougie opened this issue Aug 21, 2020 · 1 comment · Fixed by #811
Labels
🐛 bug first-timers-only good first issue

Comments

@bdougie
Copy link
Member

bdougie commented Aug 21, 2020 •
edited
Loading

Describe the bug

The action that welcomes new first time contributors is broken and needs a pull_request_target instead of pull_request to work.

see: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

place where it broke last: #808

To Reproduce

  1. Go to https://github.com/open-sauced/open-sauced/blob/main/.github/workflows/welcome.yml#L4
  2. Change to pull_request_target
  3. open a PR and check to see if a comment is made.

Expected behavior

A comment should appear when a first-time contributor opens a PR

Screenshots

Additional context
@bdougie bdougie changed the title Bug: Welcome action is broken Bug: Welcome action is broken and does not comment on PRs when opened Aug 21, 2020
@litlatte litlatte mentioned this issue Aug 21, 2020
Merged
12 tasks
@bdougie bdougie linked a pull request Aug 21, 2020 that will close this issue
Added _target on line 4 #811
Merged
12 tasks
@bdougie
Copy link
Member Author

bdougie commented Sep 18, 2020

Fixed in #811

@bdougie bdougie closed this as completed Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 bug first-timers-only good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added _target on line 4 litlatte/open-sauced
1 participant
@bdougie