Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

feat: 344 persisted fetch viewer stars #963

Merged
merged 17 commits into from
May 27, 2021
Merged

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented Apr 30, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

Adding a recommended repository section (Last 3 starred repos). Trying to keep the scope specific to adding star data. In a future PR, I will focus on making this more useful.

Future features updates to address in a different pr

  • remove repos that have already been added from the recommendation.
  • load 15 of the last starred repos
  • source star data from other users

#344

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screen Shot 2021-05-25 at 10 58 04 PM

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@todo
Copy link

todo bot commented Apr 30, 2021

Write docs on how persisted queries work

// TODO: Write docs on how persisted queries work
import {
persistedForkFetch,
persistedIssuesFetch,


This comment was generated by todo based on a TODO comment in a3c7eee in #963. cc @open-sauced.

@bdougie bdougie changed the title 344 persisted fetch viewer stars feat: 344 persisted fetch viewer stars Apr 30, 2021
@bdougie bdougie changed the title feat: 344 persisted fetch viewer stars WIP: 344 persisted fetch viewer stars Apr 30, 2021
@logs4netlify logs4netlify bot temporarily deployed to 344-persisted-fetch-viewer-stars April 30, 2021 23:34 Inactive
@bdougie bdougie changed the title WIP: 344 persisted fetch viewer stars feat: 344 persisted fetch viewer stars May 1, 2021
@bdougie bdougie changed the title feat: 344 persisted fetch viewer stars feat: (WIP) 344 persisted fetch viewer stars May 1, 2021
@bdougie bdougie force-pushed the 344-persisted-fetch-viewer-stars branch from a3c7eee to d036f63 Compare May 7, 2021 22:36
@logs4netlify logs4netlify bot temporarily deployed to 344-persisted-fetch-viewer-stars May 7, 2021 22:39 Inactive
@bdougie bdougie changed the title feat: (WIP) 344 persisted fetch viewer stars feat: 344 persisted fetch viewer stars May 11, 2021
@filiptronicek
Copy link
Sponsor Contributor

@bdougie seems that this is a WIP, can we convert it into a draft?

@bdougie bdougie marked this pull request as draft May 12, 2021 13:34
@filiptronicek filiptronicek added 🍕 enhancement 💡 feature A label to note if work is a feature labels May 12, 2021
src/components/DangerZone.js Outdated Show resolved Hide resolved
@bdougie bdougie marked this pull request as ready for review May 26, 2021 06:00
@bdougie
Copy link
Member Author

bdougie commented May 26, 2021

This is corrupting data sadly :(

@bdougie bdougie marked this pull request as draft May 26, 2021 14:01
@bdougie bdougie marked this pull request as ready for review May 26, 2021 15:15
@bdougie
Copy link
Member Author

bdougie commented May 26, 2021

Ok, it seems like it was a cache thing. Everything is working as expected.

@bdougie bdougie merged commit 75c87ac into main May 27, 2021
@bdougie bdougie deleted the 344-persisted-fetch-viewer-stars branch May 27, 2021 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍕 enhancement 💡 feature A label to note if work is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants