feat: add emoji support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Emoji Styles: |
brandonroberts
approved these changes
Jul 24, 2023
|
Nice work @a0m0rajab! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
## [2.4.0-beta.1](v2.3.0...v2.4.0-beta.1) (2023-07-24) ### 🍕 Features * add emoji support ([#63](#63)) ([82c0a3a](82c0a3a))
|
🎉 This PR is included in version 2.4.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
## [2.4.0](v2.3.0...v2.4.0) (2023-07-24) ### 🍕 Features * add emoji support ([#63](#63)) ([82c0a3a](82c0a3a))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added emoji support to the OpenGraph, at the beginning, it tried the proposed solution by @bdougie in using
node-emoji, which it did not work, then it went to use the Satori emoji system, which solved the issue. The utils file were copied fromvercel/satorirepo without any change.I kept the file without change and had all the API options to raise a discussion about which emojis to choose, right now we are using
twemoji, but there are a couple of different options which you can try from here:https://og-playground.vercel.app/
What type of PR is this? (check all applicable)
Related Tickets & Documents
fixes #50
Mobile & Desktop Screenshots/Recordings
Before:
after:
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?