fix: reactions count grammar #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdougie
approved these changes
Aug 16, 2023
brandonroberts
approved these changes
Aug 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
## [2.4.0-beta.2](v2.4.0-beta.1...v2.4.0-beta.2) (2023-08-16) ### 🐛 Bug Fixes * update reactions count grammar ([#69](#69)) ([765696a](765696a))
|
🎉 This PR is included in version 2.4.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
### [2.4.1-beta.1](v2.4.0...v2.4.1-beta.1) (2023-08-16) ### 🐛 Bug Fixes * update reactions count grammar ([#69](#69)) ([765696a](765696a))
|
🎉 This PR is included in version 2.4.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
### [2.4.1](v2.4.0...v2.4.1) (2023-08-16) ### 🐛 Bug Fixes * update reactions count grammar ([#69](#69)) ([765696a](765696a))
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
HighlightCardServiceandcard-footerfiles.In
HighlightCardService, the code has been modified to improve readability and remove unnecessary code. The changes include:In
card-footer, the code has been modified to display the correct plural form of "Reaction" based on the number of reactions.These changes improve the code quality and maintainability.
Generated using OpenSauced.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #67
Mobile & Desktop Screenshots/Recordings
Before
After
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?