Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP: sprint_val comma bug, GH: Remnant symlinks #364

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

bscottm
Copy link
Contributor

@bscottm bscottm commented Mar 12, 2024

  • Fix comma separator code segmentation fault: "ndigit - 3" can become a very large unsigned number for ndigit < 3.

  • dir_cmd: Allocate WildName from heap to reduce stack pressure.

  • Github CI/CD: Remnant symlink issue reappeared, afflicting the makefile-based build. For better or worse, the workaround is now dependent on specific Python versions that must be removed, unlinked and any remnant symlinks that HomeBrew decided it needed to install in /usr/local/bin. The Python upgrade is triggered by the sdl2_ttf package.

    According to the Github image maintainers, this is an old, known issue in macOS images that originates inside of Homebrew.

- Fix comma separator code segmentation fault: "ndigit - 3" can become a
  very large unsigned number for ndigit < 3.

- dir_cmd: Allocate WildName from heap to reduce stack pressure.

- Github CI/CD: Remnant symlink issue reappeared, afflicting the
  makefile-based build. For better or worse, the workaround is now
  dependent on specific Python versions that must be removed, unlinked
  and any remnant symlinks that HomeBrew decided it needed to install in
  /usr/local/bin. The Python upgrade is triggered by the sdl2_ttf
  package.

  According to the Github image maintainers, this is an old, known issue
  in macOS images that originates inside of Homebrew.
@bscottm
Copy link
Contributor Author

bscottm commented Mar 12, 2024

@pkoning2: The remnant symlink issue is pressingly urgent, since it impacted the makefile-based builds for macOS.

@pkoning2 pkoning2 merged commit ae9e57f into open-simh:master Mar 12, 2024
18 checks passed
@bscottm bscottm deleted the scp-gh-fixes branch March 13, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants