Does nu18 or n1821 include 18-year-olds?

[MaxGhenis]

The CPS records_variables.json file describes nu18 as

Number of people under 18 years old in the filing unit.

, n1821 as

Number of people over 18 and under 21 years old in the filing unit

and n21 as

Number of people 21 years old or older in the filing unit

Based on this language I'm not clear on whether nu18 or n1821 includes 18-year-olds.

[MaxGhenis]

The UBI parameters describe _UBI1 as

UBI benefit for those under 18

and _UBI2 as

UBI benefit for those 18 through 20

[martinholmer]

@MaxGhenis, Thanks for the documentation bug report.
Pull request #1672 clarifies that n1821 is number of people age 18-20.

[martinholmer]

@MaxGhenis, In the next version of Tax-Calculator we'll change the variable n1821 to be n1820 so that the variable name says what it means. Again, thanks for your bug report.

@MattHJensen @andersonfrailey

[martinholmer]

The merge of pull request #1871 completes the renaming of the old data variable n1821 to n8120.
Now the more accurate name is used both in the latest PUF data file and in the latest CPS data file.