Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix #129

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Bug Fix #129

merged 1 commit into from
Jan 13, 2021

Conversation

calibeach
Copy link
Contributor

Fixed bug where hasownproperty returned error when currentNode is null.

Types of changes

  • [X Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Recoilize produced an error when currentNode's value was null

Approach

Added a line to ensure that currentNode is an object before traversing through Fiber tree to get names of atoms and selectors

Fixed bug where hasownproperty returned error when currentNode is null.
@Janis-H Janis-H merged commit bdfa4a1 into open-source-labs:staging Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants