Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not seem to work with react-router #145

Closed
josiahgallen opened this issue Oct 11, 2019 · 3 comments · Fixed by #149
Closed

Does not seem to work with react-router #145

josiahgallen opened this issue Oct 11, 2019 · 3 comments · Fixed by #149

Comments

@josiahgallen
Copy link

When following the set up instructions provided in the README this tool breaks the application if the app has react-router-dom. Currently using react-router-dom v5.1.2.

I see this error when attempting to include in my project.
Screen Shot 2019-10-10 at 8 32 27 PM

Seems like acorn is choking on something in router... I am unsure if acorn was pulled in as a dependency of reactime or another one of the packages i have in my project... regardless, when i comment out the router code reactime works, when i have it in the code it breaks.

@andynullwong
Copy link
Contributor

Thank you for reporting this, since this was missed in our original testing, to clarify, did your React router crash on runtime or only after clicking on your Components?

@mikestaub
Copy link

I also hit this error, the app crashes immediately before any user interaction.

@rajeebbanstola
Copy link
Contributor

Hi @josiahgallen, @mikestaub

We just released Reactime 3.0 which supports React Router. Update both the npm package and Chrome extension and let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants