Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insert overload method #1110

Merged
merged 1 commit into from Dec 3, 2019
Merged

Add insert overload method #1110

merged 1 commit into from Dec 3, 2019

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Dec 2, 2019

According to the conclusion in issue #1046, the insert should follow the standard container members like vector::push_back, which will always have a const T& and a T&& overload.
This patch is to fix this problem.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 92.136% when pulling 1efa93b on dota17:insert_overload into 9e0d70a on open-source-parsers:master.

BillyDonahue
BillyDonahue approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@BillyDonahue BillyDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. careful about the ABI break though.

@dota17 dota17 merged commit a0bd9ad into open-source-parsers:master Dec 3, 2019
@dota17 dota17 deleted the insert_overload branch January 13, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyDonahue BillyDonahue BillyDonahue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dota17 @coveralls @BillyDonahue