Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing ccache from cmake #1131

Closed

Conversation

conjam
Copy link

@conjam conjam commented Jan 9, 2020

seeing issues with ccache when using CMake -- removed it as per #737.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.699% when pulling 032e3e1 on conjam:remove_ccache_cmake into 6bc55ec on open-source-parsers:master.

@dota17
Copy link
Member

dota17 commented Jan 13, 2020

@conjam
Thanks for your PR.
But from #737 (comment), is it better to change to not search outside $PATH?

Copy link
Contributor

@ClausKlein ClausKlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conjam
Copy link
Author

conjam commented Feb 12, 2020

@conjam
Thanks for your PR.
But from #737 (comment), is it better to change to not search outside $PATH?

from my understanding, find_program() in cmake has ... issues. I played around with setting PATH, but it still breaks my build, even with the work around mentioned in the thread (I was trying to use bazel wrapping cmake). In the end I just ported this to bazel -- could submit PR if you like, figure that would just cause you headaches down the road.

Regardless, a better fix seems to be in so I'll close this

@conjam conjam closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants