Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile warnning using cmake #1132

Merged
merged 1 commit into from Jan 20, 2020

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Jan 13, 2020

While build using cmake locally, i got these warinnings:

[ 90%] Building CXX object src/test_lib_json/CMakeFiles/jsoncpp_test.dir/main.cpp.o
/data/jsoncpp/src/test_lib_json/main.cpp: In member function ‘virtual void TestCharReaderAllowDropNullTestissue178::runTestCase()’:
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
   };
   ^
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
/data/jsoncpp/src/test_lib_json/main.cpp:3324:3: warning: missing initializer for member ‘TestCharReaderAllowDropNullTestissue178::runTestCase()::TestSpec::onRoot’ [-Wmissing-field-initializers]
[100%] Linking CXX executable jsoncpp_test

this PR will fix them.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.699% when pulling ab4bd7b on dota17:fix-cmake-warn into 6bc55ec on open-source-parsers:master.

@dota17 dota17 merged commit 6317f9a into open-source-parsers:master Jan 20, 2020
@dota17 dota17 deleted the fix-cmake-warn branch January 20, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants