Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ccache right #1139

Merged
merged 2 commits into from Feb 13, 2020
Merged

Use ccache right #1139

merged 2 commits into from Feb 13, 2020

Conversation

ClausKlein
Copy link
Contributor

The ccache must be setup before call project() at CMakeLists.txt
cmakelint all cmake files

This fix #1138 too

@ClausKlein
Prevent cmakelint warnings
3a970e8 
Use 4 spaces for indent, no tabs
@ClausKlein
Use ccache right
bd6a3d0 
fix indents too at CMakeLists.txt
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.701% when pulling bd6a3d0 on ClausKlein:feature/fix_cmakelint_warnigs into edf528e on open-source-parsers:master.

dota17
dota17 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@dota17 dota17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.
If there is no objection, it will be merged soon.

@baylesj baylesj merged commit a6fe8e2 into open-source-parsers:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dota17 dota17 dota17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent cmakelint warnings
4 participants
@ClausKlein @coveralls @dota17 @baylesj