Make throw.*Error print msg when built with JSON_USE_EXCEPTION=0
#1150
Conversation
| JSONCPP_NORETURN void throwRuntimeError(String const& msg) { abort(); } | ||
| JSONCPP_NORETURN void throwLogicError(String const& msg) { abort(); } | ||
| JSONCPP_NORETURN void throwRuntimeError(String const& msg) { | ||
| std::cerr << msg << std::endl; |
There was a problem hiding this comment.
I'm afraid noreturn function should not return anything.
There was a problem hiding this comment.
I'm not seeing the issue. These functions don't return.
They do have side-effects before aborting, but then there is nothing wrong with a no-return function having side effects.
Edit: If I'm missing your point, could you please be more specific about what changes you want?
There was a problem hiding this comment.
We are a library and we don't control std::cerr. We must not reach into the app and decide what information should be put to std::cerr. The app might have a completely different logging system to which this error should be put. It's an app-level decision. The most we should do is allow for a user-defined error handling callback. Then if they want to write to std::cerr they can install the behavior to do so, but we should not be making that decision for them.
cdunn2001
dismissed
dota17’s stale review
I think this is ok. Since the program is about to abort(), all bets are off. Might as well write to stderr first, since this is a hard-crash, already a security proble.
Tested: used this to debug an issue in my code.