CMakeLists.txt: Treat conversion warning as error only with JSONCPP_W…

[bkuhls]

…ITH_WARNING_AS_ERROR=ON

Fixes errors when building with buildroot:
http://autobuild.buildroot.net/?reason=jsoncpp-1.7.2

Signed-off-by: Bernd Kuhls bernd.kuhls@t-online.de

[cdunn2001]

This is fine with me, but I'm curious: Exactly what was the problem?

Also, please take a quick look at #465 for the Intel compiler, and adjust if necessary. Then I'll merge this.

[bkuhls]

Here is a quote of the error message fixed by my patch from one of the buildroot autobuilder compile logs
http://autobuild.buildroot.net/results/6ad/6ada6b4fdc562d2a8abe8a88a76fc0fef819c929/build-end.log

/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp: In member function 'void Json::Reader::readNumber()':
/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp:433:40: error: conversion to 'char' from 'int' may alter its value [-Werror=conversion]
/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp:436:40: error: conversion to 'char' from 'int' may alter its value [-Werror=conversion]
/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp:438:42: error: conversion to 'char' from 'int' may alter its value [-Werror=conversion]
/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp:442:40: error: conversion to 'char' from 'int' may alter its value [-Werror=conversion]
/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp:444:42: error: conversion to 'char' from 'int' may alter its value [-Werror=conversion]
/home/test/autobuild/instance-3/output/build/jsoncpp-1.7.2/src/lib_json/json_reader.cpp:446:42: error: conversion to 'char' from 'int' may alter its value [-Werror=conversion]

Regarding PR #465 I can not help, sorry, I do not have an Intel compiler at hand.

[cdunn2001]

Sorry for delays. Vacation.