Fix compilation errors for downstream projects caused by incorrect pkconfig paths #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gconfig paths Recent commit 911e2b0 ("By default use <prefix> relative paths when installing") introduced relative install paths in CMake. But this interacts badly with commit e6f1cff from a year ago: now, the paths in `pkgconfig/jsoncpp.pc` are relative, which is incorrect. Before 911e2b0 (1.7.2 on Archlinux), this was correct: $ head -4 /usr/lib/pkgconfig/jsoncpp.pc prefix=/usr exec_prefix=${prefix} libdir=/usr/lib includedir=/usr/include After 911e2b0 (1.7.3 on Archlinux), this is now incorrect: $ head -4 /usr/lib/pkgconfig/jsoncpp.pc prefix=/usr exec_prefix=${prefix} libdir=lib includedir=include This change causes hard-to-debug compilation errors for projects that depend on jsoncpp, for instance: CXXLD libring.la /tmp/ring-daemon/src/ring-daemon/src/../libtool: line 7486: cd: lib: No such file or directory libtool: error: cannot determine absolute directory name of 'lib' make[3]: *** [Makefile:679: libring.la] Error 1 This is because jsoncpp contributes `-Llib -ljsoncpp` to the LDFLAGS, via the pkg-config machinery. Notice the relative path in `-Llib`. To fix this, simply revert commit e6f1cff ("Fix custom includedir & libdir substitution in pkg-config"). The change in 911e2b0 should have the same effect. See open-source-parsers#279, open-source-parsers#470 for references.
|
Thanks! |
|
Great, thanks for the merge! Would you mind spinning up a new release with this fix? |
|
Done: A "pre-release" for now. If anybody reports a problem, we might need your help to address it. |
|
Could you comment on #497? We might need to revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commit 911e2b0 ("By default use relative paths when
installing") introduced relative install paths in CMake. But this
interacts badly with commit e6f1cff from a year ago: now, the paths in
pkgconfig/jsoncpp.pcare relative, which is incorrect.Before 911e2b0 (1.7.2 on Archlinux), this was correct:
After 911e2b0 (1.7.3 on Archlinux), this is now incorrect:
This change causes hard-to-debug compilation errors for projects that
depend on jsoncpp, for instance:
This is because jsoncpp contributes
-Llib -ljsoncppto the LDFLAGS, viathe pkg-config machinery. Notice the relative path in
-Llib.To fix this, simply revert commit e6f1cff ("Fix custom includedir &
libdir substitution in pkg-config"). The change in 911e2b0 should have
the same effect.
See #279, #470 for references.