Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinCE Compatibility Fix #9

Closed
wants to merge 4 commits into from
Closed

WinCE Compatibility Fix #9

wants to merge 4 commits into from

Conversation

pffang
Copy link
Contributor

@pffang pffang commented Jul 10, 2014

WinCE Compatibility Fix:
Make jsoncpp can be compiled and use with WinCE SDK.

str.imbue and std::locale::classic() are not supported on WINCE
Sorry. My editor change LF to CR+LF automatically.
@pffang
Copy link
Contributor Author

pffang commented Jul 10, 2014

Sorry, my editor change the line endings from LF to CR+LF automatically.
I'll fix it.

@cdunn2001
Copy link
Contributor

You can use CRLF endings on your machine, and let git auto-convert between your files and the repository.

On Windows, use this:

git config --global core.autocrlf true

On Linux or Mac, you would use this:

git config --global core.autocrlf input

@cdunn2001
Copy link
Contributor

I am fine with the "reader" change.

For the "writer" change, you would be losing our recent bug-fix for numeric locales.

Are you certain that your compiler is up-to-date? Can you tell us what compiler you use?

@pffang
Copy link
Contributor Author

pffang commented Jul 11, 2014

Microsoft Visual C++ 2008 and Windows CE 5.0 Standard Software Development Kit (can be download here http://www.microsoft.com/en-us/download/details.aspx?id=17310)
Sadly, It has an old and poor STL support, no__ header, only has <locale.h> and setlocale().

cdunn2001 added a commit that referenced this pull request Jul 11, 2014
This reverts commit 0db9d6e, reversing
changes made to 06dcb1f.

For discussion, see
  #9
  #3
cdunn2001 added a commit that referenced this pull request Jul 11, 2014
In some locales (e.g. de_DE) floats have commas instead of
dots, but JSON requires dots.
See:
  #9
  #3
@cdunn2001
Copy link
Contributor

Rebased your commit to master branch. Thank you for the submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants