[BUG] Consider card has manual reset even if its first review kind is not learning

[L-M-Sherlock]

Now, we need to change this line
if i == 0 and (revlog.review_kind not in (0, 2)) and not has_again(revlogs):
to
if i == 0 and (revlog.review_kind not in (0, 2)) and not (has_again(revlogs) or has_manual_reset(revlogs)):
and define the function has_manual_reset.

By manual reset, I mean manual reset without the manual rating in the revlog (#51).

Originally posted by @user1823 in open-spaced-repetition/fsrs4anki#191 (comment)

[user1823]

By manual reset, I mean manual reset without the manual rating in the revlog (open-spaced-repetition/fsrs4anki-helper#51).

I thought about it again and realised that it is better to include both manual reset with revlog and without revlog.

The reason is that it doesn't actually matter whether the manual entry is there in the revlogs or not. If the card was reset, it should not be withheld because the first review in the revlog was not of learn or relearn type.

Originally posted by @user1823 in open-spaced-repetition/fsrs4anki#191 (comment)

[L-M-Sherlock]

@mantixero, here is the patch: fsrs4anki-helper.zip

It could fix the four strange cards in your collection.

[mantixero]

Thank you. I no longer see a Reset all cards, so I should do a Reschedule all cards, correct?

[user1823]

Yes

[mantixero]

After rescheduling all cards with the newest patch, it looks like I have custom data for all cards, including the ones that went back to the Learn state without a 1 Rating and/or the Relearn state, and including the 4 cards with extreme intervals. My main deck has about the same reviews as the last rescheduling, but my kanji deck went from 668 reviews down to 253, so there must have been around 415 cards in that deck without custom data that now have been fixed.

Since a few days ago, I've been waiting to resume my reviews until a satisfactory patch was released, and this looks like the wait was worth it. Thank you both so much for your help. I'm relieved not only that I don't have to go back to the v2 scheduler and its many repetitions, but that FSRS now has believable intervals that I'm more confident about. I'll continue to use it and see where it takes me as far as mature card retention rate.

Just to clarify: the improvements in this helper patch were not in the optimizer, correct? If the optimizer were to have this patch applied, would it be worth re-running it to get new w values?

[user1823]

The improvements in this helper patch were not in the optimizer, correct? If the optimizer were to have this patch applied, would it be worth re-running it to get new w values?

Yes, there was no new patch applied to the optimizer. So, you don't need to re-run the optimizer.

[user1823]

@mantixero
Would you now reconsider your review of FSRS4Anki add-on at AnkiWeb?

[L-M-Sherlock]

😁I hope my efforts worth a thumb on the helper add-on page.

[L-M-Sherlock]

I will merge and release the patch tomorrow.

[mantixero]

Sounds great! I've updated my review on the Helper add-on page, and left room for you to comment (if you want) with a specific revision number you would recommend for similarly affected users.