Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Simulator - What is recall_repetitions, forget_repetitions, new_repetitions, and period_len #16

Closed
kuroahna opened this issue Sep 22, 2022 · 5 comments · Fixed by #25
Labels
question Further information is requested

Comments

@kuroahna
Copy link

I'm testing the simulator and this is really cool, but I'm not 100% sure what recall_repetitions, forget_repetitions, new_repetitions, and period_len are

  1. Is recall_repetitions how many repetitions it takes to pass a "review" card? For example, in Anki, when I review an existing card, and I press good, that means it is 1 repetition. Not sure what happens when you press Again (fail card). I suppose this is counted for in forget_repetitions
  2. Is forget_repetitions how many repetitions it takes to review a card? For example, in Anki, in the options, there is "Lapses" section and I have the steps configured as "2 60", so would forget_repetitions be 2 here?
  3. Is new_repetitions how many repetitions it takes to learn a "new" card? For example, in Anki, in the options, there is the "New cards" section, and I have the steps configured as "1 5 60", so would new_repetitions be 3 here?
  4. Not sure what period_len is. In the graphs, I see "review cards per day (14 days average)" and "repetitions per day (14 days average)" since period_len=14 by default. Does this mean that you are adding a data point for every 14 days? So if I want to see the "review cards per day" and "repetitions per day" for every day, then I would set this to 1?
@L-M-Sherlock
Copy link
Member

  1. Yes, if you press hard, good and easy when you review, Anki will pass the card. So you only have 1 repetition for a card.
  2. You can refer to the Anki simulator add-on https://ankiweb.net/shared/info/817108664
  3. Same to above
  4. It’s used to smooth the curve. You can see this wiki page https://en.m.wikipedia.org/wiki/Moving_average

@L-M-Sherlock L-M-Sherlock added the question Further information is requested label Sep 22, 2022
@kuroahna
Copy link
Author

Thanks. I had a look at Anki simulator addon

image

  1. I assume forget_repetitions is the number of "Lapse steps" seen above
  2. And same for new_repetitions. This is the number of "Learning steps"

@L-M-Sherlock
Copy link
Member

Not very accurate. If you lapse steps is "2 60", you could press the 'again' button consistently. And press 'easy' could pass these steps.

@kuroahna
Copy link
Author

Right, that makes sense.

Sorry, but I feel very dumb, I still don't really understand or know what forget_repetitions and new_repetitions is. I looked at Anki Simulator addon that you linked, but they don't mention anything about forget_repetitions or new_repetitions. I thought it was the number of lapse steps and number of learning steps, but from your response above, I don't think that's the case.

I also looked at their source code and all I can find is

        number_of_learning_steps: int,
        number_of_lapse_steps: int,

I don't see anything related to forget_repetitions or new_repetitions like you have mentioned. Should I leave things as default then?

recall_repetitions = 1
forget_repetitions = 2
new_repetitions = 1

I wanted a rough estimation of how many reviews I would get using fsrs4anki using your simulator if I had lapse steps 2 60 and learning steps 1 5 60 in Anki, which is why I set them to

recall_repetitions = 1
forget_repetitions = 2
new_repetitions = 3

but I'm still not sure if this is what I should do

@L-M-Sherlock
Copy link
Member

The accurate repetitions are only from your actual review logs. I will implement it in the simulator in the future.

But you can use the number of steps as a rough estimation.

@L-M-Sherlock L-M-Sherlock linked a pull request Sep 24, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants