[8.0][account_budget_variance] Adding new module account_budget_variance #2
Conversation
|
Changes Unknown when pulling dd10a93 on mikevhe18:account_budget_variance into ** on open-synergy:8.0**. |
Current coverage is 100% (diff: 100%)
|
| "author": "OpenSynergy Indonesia", | ||
| "license": "AGPL-3", | ||
| "installable": True, | ||
| "application": True, |
|
|
||
| @api.multi | ||
| @api.depends('variance_amount', 'planned_amount') | ||
| def _compute_variance_percent(self): |
There was a problem hiding this comment.
Mike ini kenapa ga disatuin aja di satu fungsi dengan _compute_variance_amount?
mikevhe18
force-pushed
the
account_budget_variance
branch
from
dd10a93
to
0da713a
Compare
|
Changes Unknown when pulling 0da713a on mikevhe18:account_budget_variance into ** on open-synergy:8.0**. |
1 similar comment
|
Changes Unknown when pulling 0da713a on mikevhe18:account_budget_variance into ** on open-synergy:8.0**. |
| rec.practical_amount - rec.planned_amount | ||
| if rec.variance_amount: | ||
| rec.variance_percent =\ | ||
| (rec.variance_amount / rec.planned_amount) |
There was a problem hiding this comment.
@mikevhe18 ike ini ati-ati error division by zero. Klo planned_amountnya == 0 error dia.
Revision Avoiding division by zero Avoiding division by zero
mikevhe18
force-pushed
the
account_budget_variance
branch
from
0da713a
to
bda2bb2
Compare
|
Changes Unknown when pulling bc3f01f on mikevhe18:account_budget_variance into ** on open-synergy:8.0**. |
Issue #1