Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0][hr_worked_days_compute_holiday] Adding new module hr_worked_days_compute_holiday #16

Merged
merged 1 commit into from
Feb 10, 2017
Merged

[8.0][hr_worked_days_compute_holiday] Adding new module hr_worked_days_compute_holiday #16

merged 1 commit into from
Feb 10, 2017

Conversation

mikevhe18
Copy link
Contributor

No description provided.

@mikevhe18 mikevhe18 force-pushed the 8.0-hr_worked_days_compute_holiday branch 2 times, most recently from 27c6cfc to 20d4d7f Compare February 7, 2017 05:07
@coveralls
Copy link

coveralls commented Feb 7, 2017 •
edited
Loading

Coverage Status

Coverage increased (+2.2%) to 82.843% when pulling 20d4d7f on mikevhe18:8.0-hr_worked_days_compute_holiday into e757171 on open-synergy:8.0.

@codecov-io
Copy link

codecov-io commented Feb 7, 2017 •
edited
Loading

Codecov Report

Merging #16 into 8.0 will increase coverage by 1.83%.

@@            Coverage Diff            @@
##              8.0     #16      +/-   ##
=========================================
+ Coverage   80.66%   82.5%   +1.83%     
=========================================
  Files           8       9       +1     
  Lines         181     200      +19     
=========================================
+ Hits          146     165      +19     
  Misses         35      35
Impacted Files Coverage Δ
...r_worked_days_compute_holiday/models/hr_payslip.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e757171...8732354. Read the comment docs.

andhit-r
andhit-r requested changes Feb 7, 2017
View reviewed changes
Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mike,

  1. Pembuatan payslip melalui menu Employee Payslips berhasil. Perhitungannya ok.
  2. Pembuatan payslip melalui menu Payslip Batches ada error. Video ada di https://youtu.be/coer4Xo3jrU

@mikevhe18 mikevhe18 force-pushed the 8.0-hr_worked_days_compute_holiday branch from 20d4d7f to a03ab05 Compare February 8, 2017 03:43
@coveralls
Copy link

Coverage Status

Coverage increased (+1.8%) to 82.5% when pulling a03ab05 on mikevhe18:8.0-hr_worked_days_compute_holiday into e757171 on open-synergy:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.8%) to 82.5% when pulling a03ab05 on mikevhe18:8.0-hr_worked_days_compute_holiday into e757171 on open-synergy:8.0.

@mikevhe18
Adding new module hr_worked_days_compute_holiday
8732354 
Modifiy method get_worked_day_lines

Fixing travis error

Revision

Fixing Travis Error
@mikevhe18 mikevhe18 force-pushed the 8.0-hr_worked_days_compute_holiday branch from a03ab05 to 8732354 Compare February 8, 2017 03:49
@coveralls
Copy link

coveralls commented Feb 8, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.8%) to 82.5% when pulling 8732354 on mikevhe18:8.0-hr_worked_days_compute_holiday into e757171 on open-synergy:8.0.

andhit-r
andhit-r requested changes Feb 8, 2017
View reviewed changes
Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikevhe18 masih ada yang salah. video di: https://youtu.be/xGwB3jjAnwY

@mikevhe18
Copy link
Contributor Author

@andhit-r Mas, untuk validasi countrynya yang dilihat bukan dari home address mas, tetapi berdasarkan country di working address. Kalau misalnya contoh home address di Singapure, working addressnya di Indonesia, bearti seharusnya public holiday yang diitung khan yang di Indonesia

@andhit-r
Copy link
Member

andhit-r commented Feb 8, 2017

Hoo oke cek dengan working address klo gitu

@andhit-r
Copy link
Member

andhit-r commented Feb 9, 2017

@mikevhe18 msh salah mike. Video: https://youtu.be/hBqABRDbUnU

@andhit-r andhit-r merged commit 8d6c4cf into open-synergy:8.0 Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andhit-r andhit-r andhit-r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikevhe18 @coveralls @codecov-io @andhit-r