[8.0.1.2.0][hr_timesheet_computation_overtime] #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 8.0 #243 +/- ##
==========================================
+ Coverage 56.42% 56.48% +0.05%
==========================================
Files 296 298 +2
Lines 6127 6140 +13
==========================================
+ Hits 3457 3468 +11
- Misses 2670 2672 +2
Continue to review full report at Codecov.
|
andhit-r
requested changes
Nov 11, 2020
| @api.constrains( | ||
| "sheet_id", | ||
| "state", | ||
| "company_id.overtime_check_timesheet", |
There was a problem hiding this comment.
Constrains tidak bisa menggunakan dot notation. Cukup sheet_id dan state
| ) | ||
| def _check_timesheet(self): | ||
| obj_overtime = self.env[self._name] | ||
| if self.state in ["confirm", "valid"]: |
There was a problem hiding this comment.
Suggested change
| if self.state in ["confirm", "valid"]: | |
| if self.state in ["confirm", "valid"] and not self.sheet_id and self.company_id.overtime_check_timesheet: |
Comment on lines
52
to
57
| criteria = [ | ||
| ("sheet_id", "=", False), | ||
| ("company_id.overtime_check_timesheet", "<>", False), | ||
| ] | ||
| if obj_overtime.search_count(criteria) > 0: | ||
| raise UserError(_("Timesheet cannot be empty")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.