Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching application ranges off #419

Closed
Yuri05 opened this issue Feb 18, 2021 · 7 comments
Closed

Allow switching application ranges off #419

Yuri05 opened this issue Feb 18, 2021 · 7 comments

Comments

@Yuri05
Copy link
Member

Yuri05 commented Feb 18, 2021

For the time profile plots in multiple administration simulation 3 time ranges are plotted: full range, first application range, last application range.
It should be possible to deactivate some of them (e.g. plot last application range only)

@Yuri05 Yuri05 added this to Accepted in RE Version 1.2 via automation Feb 25, 2021
@pchelle
Copy link
Collaborator

pchelle commented Mar 22, 2021

@Yuri05 , do you remember which simulation files have multiple applications ?

@Yuri05
Copy link
Member Author

Yuri05 commented Mar 22, 2021

@pchelle Here are 2 fast running simulations (1 IV and 1 PO) with 3 administrations each
RE_PBPK_Sims_3_Apps.zip

@pchelle
Copy link
Collaborator

pchelle commented Mar 22, 2021

Great. Thanks !

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Mar 22, 2021
… on/off inclusion

Enum ApplicationRanges was introduce to help implementing this fix
@Yuri05 Yuri05 closed this as completed in db7006d Mar 23, 2021
RE Version 1.2 automation moved this from Accepted to Fixed Mar 23, 2021
@Yuri05
Copy link
Member Author

Yuri05 commented Apr 12, 2021

Turning application ranges on/off must be done per simulation set, not per wokflow.
At the moment it's done on the workflow level. Which (apart from missing flexibility) also results in some side effects. E.g. if I have 2 simulation sets in my workflow - one for a single administration and one for multiple - and I set the total application range to false: no time profiles are plotted for the single simulation at all.

@Yuri05 Yuri05 reopened this Apr 12, 2021
RE Version 1.2 automation moved this from Fixed to In progress Apr 12, 2021
@pchelle
Copy link
Collaborator

pchelle commented Apr 12, 2021

My bad, I thought it was supposed to be common between the simulations.
So, it means the option should be defined directly as an input/option of the SimulationSet objects, correct ?

@Yuri05
Copy link
Member Author

Yuri05 commented Apr 12, 2021

So, it means the option should be defined directly as an input/option of the SimulationSet objects, correct ?

yes, applicationRanges should become an optional input of a simulation set

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Apr 13, 2021
@Yuri05 Yuri05 closed this as completed in a55e173 Apr 13, 2021
RE Version 1.2 automation moved this from In progress to Fixed Apr 13, 2021
@Yuri05
Copy link
Member Author

Yuri05 commented Apr 15, 2021

ospsuite.reportingengine 1.2.32
bug.zip

Warning: 15/04/2021 - 14:37:27 : source: argument 'c(applicationRanges)' is of type 'character', but expected 'logical'!
Error: source: argument 'c(applicationRanges)' is of type 'character', but expected 'logical'!

@Yuri05 Yuri05 reopened this Apr 15, 2021
RE Version 1.2 automation moved this from Fixed to In progress Apr 15, 2021
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Apr 16, 2021
… of selected applications

Documentation accordingly
@Yuri05 Yuri05 closed this as completed in c4887f1 Apr 16, 2021
RE Version 1.2 automation moved this from In progress to Fixed Apr 16, 2021
@Yuri05 Yuri05 moved this from Fixed to Verified in RE Version 1.2 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants