Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeanModel/PopWorkflow: Residuals across all simulation: add missing plot types #888

Closed
Yuri05 opened this issue Jul 7, 2022 · 1 comment

Comments

@Yuri05
Copy link
Member

Yuri05 commented Jul 7, 2022

At the moment we have only histogram of residuals and qq-plot here.
Other GOF plots are missing and should be added as well:

  • Predicted vs observed
  • Residuals vs observed
  • Residuals vs time

Issue #887 applies for these plot types as well:

  • Split by output
  • Colouring by SimulationSet the same in all plots
@Yuri05 Yuri05 added this to To do in Version 2.1 / 2.2 via automation Jul 28, 2022
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Sep 28, 2022
…ts of residuals across all simulations by output
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Oct 13, 2022
…ts of residuals across all simulations by output
Yuri05 pushed a commit that referenced this issue Oct 19, 2022
* Fixes #887 #888 plots of residuals across all simulations by output

* Wrap functions to simplify goodness of fit captions

* Fixes #876 introduce default statistics Fixes #875 superscript th

* Default theme defines different colors in goodness of fit plots

TODO: Output and SimulationSets needs to manage the property

* Update doc examples

* Update tests and their results

* Reverse time profile plot methods

* Rename function names that would require quotes

* Add webshot in suggested packages

(hopefully, this will enforce its installation in the vignettes)

* Remove use of rlang

Checking if rlang might be responsible for errors in tests

* Remove unwanted warnings in tests

* Compare exported values without legend containing unicode characters

* Use */ in geomean caption instead of unicode

* Fix documentation of function getStatisticsFromType
@pchelle
Copy link
Collaborator

pchelle commented Nov 24, 2022

Should be fixed by PR #939

@pchelle pchelle closed this as completed Nov 24, 2022
Version 2.1 / 2.2 automation moved this from To do to Fixed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants