Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification workflow / Time profile plots: add 2nd y-axis automatically if required #985

Closed
Yuri05 opened this issue Feb 2, 2023 · 0 comments · Fixed by #993
Closed

Comments

@Yuri05
Copy link
Member

Yuri05 commented Feb 2, 2023

At the moment, when running a Qualification Workflow with time profile plots coming from PK-Sim:
if a plot contains the second Y axis - it is ignored with warning:

! Warning	Right Axis not available yet in tlf package,
Wagner 1981 - 0.5mg po - Digoxin - PO - 0.5 mg - Urine - agg. (n=6)-Digoxin-Kidney-Urine-ArithmeticMeancould not be added

In such a case RE should automatically add the 2nd y-axis, without any need for the user to specify this in the configuration

Related to: Open-Systems-Pharmacology/TLF-Library#392

@Yuri05 Yuri05 added this to To do in Version 2.1 / 2.2 via automation Feb 2, 2023
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Feb 20, 2023
…al axis in time profiles

Also Fixes Open-Systems-Pharmacology#985

The fix requires PR [407](Open-Systems-Pharmacology/TLF-Library#407) from tlf package and might have side effects on the legend order of other plots performed by the reporting engine
Version 2.1 / 2.2 automation moved this from To do to Fixed Feb 24, 2023
Yuri05 pushed a commit that referenced this issue Feb 24, 2023
…993)

* Fixes #934 qualification workflows handle dual axis in time profiles

Also Fixes #985

The fix requires PR [407](Open-Systems-Pharmacology/TLF-Library#407) from tlf package and might have side effects on the legend order of other plots performed by the reporting engine

* Fix vignette fail due to update in tlf

* Use fix default values for qualification time profile properties

* Update documentation

* Comment and remove duplicated code chunk
@Yuri05 Yuri05 moved this from Fixed to Verified in Version 2.1 / 2.2 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment