-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What are the PR MERGE requirements? #41
Comments
I'd suggest that 1 approval from Approver or Maintainer should be enough for language-specific decision. It may be different for the specification repo where we want to get to consensus on every issue. So perhaps everybody has to sign off. Or at least 3 people |
BTW, this is related to the backlog proposal: #52 Consider not just who can merge PRs, but also:
In this case, though: I recommend 2 approvals for interface changes, and 1 approval for SDK and other changes. |
The text was updated successfully, but these errors were encountered: