Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the PR MERGE requirements? #41

Closed
bogdandrutu opened this issue May 14, 2019 · 2 comments · Fixed by #182
Closed

What are the PR MERGE requirements? #41

bogdandrutu opened this issue May 14, 2019 · 2 comments · Fixed by #182

Comments

@bogdandrutu
Copy link
Member

  • For example get at least N approvals?
  • Only maintainer can merge after N approvals?
@SergeyKanzhelev
Copy link
Member

I'd suggest that 1 approval from Approver or Maintainer should be enough for language-specific decision. It may be different for the specification repo where we want to get to consensus on every issue. So perhaps everybody has to sign off. Or at least 3 people

@tedsuo
Copy link
Contributor

tedsuo commented May 28, 2019

BTW, this is related to the backlog proposal: #52

Consider not just who can merge PRs, but also:

  • Who triages new issues?
  • Who can close unresolved issues? Or otherwise reject proposals?

In this case, though: I recommend 2 approvals for interface changes, and 1 approval for SDK and other changes.

SergeyKanzhelev added a commit that referenced this issue Sep 18, 2019
SergeyKanzhelev added a commit that referenced this issue Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants