Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify GC scopes to include GitHub permissions. #2025

Merged
merged 3 commits into from
Apr 14, 2024
Merged

Modify GC scopes to include GitHub permissions. #2025

merged 3 commits into from
Apr 14, 2024

Conversation

austinlparker
Copy link
Member

Currently, the TC are the only org users with org admin access. This PR clarifies that the GC also is responsible for GitHub org level actions.

trask
trask approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me, but would like to hear if @open-telemetry/technical-committee has any concerns

reyang
reyang approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

jpkrohling
jpkrohling approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need 2/3 approvals for this change. I would also be nice to give the TC a heads-up.

@reyang
Copy link
Member

reyang commented Apr 2, 2024

I believe we need 2/3 approvals for this change. I would also be nice to give the TC a heads-up.

I'll bring this up during the TC meeting this week.

@austinlparker austinlparker merged commit 77d92c3 into open-telemetry:main Apr 14, 2024
3 checks passed
@austinlparker austinlparker deleted the updateGitHubPermissionScope branch April 14, 2024 00:56
@trask trask mentioned this pull request Apr 16, 2024
Closed
@austinlparker austinlparker mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@jmacd jmacd jmacd left review comments

@jack-berg jack-berg jack-berg left review comments

@jpkrohling jpkrohling jpkrohling approved these changes

@tedsuo tedsuo tedsuo approved these changes

@trask trask trask approved these changes

@svrnm svrnm svrnm approved these changes

@danielgblanco danielgblanco danielgblanco approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@reyang reyang reyang approved these changes

@alolita alolita Awaiting requested review from alolita alolita is a code owner

@mtwo mtwo Awaiting requested review from mtwo mtwo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet