Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement compression in WebSocket client #101

Closed
tigrannajaryan opened this issue Jul 14, 2022 · 0 comments · Fixed by #122
Closed

Implement compression in WebSocket client #101

tigrannajaryan opened this issue Jul 14, 2022 · 0 comments · Fixed by #122
Assignees
@tigrannajaryan

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Jul 14, 2022 •
edited

We also have an open issue in the spec that asks to verify it: open-telemetry/opamp-spec#92

Ideally we want an automated test. If automated test is impossible then we need to verify manually and close the issue.
@tigrannajaryan tigrannajaryan added the help wanted Extra attention is needed label Jul 14, 2022
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Jul 29, 2022
@tigrannajaryan
Implement compression for WebSocket transport
150072a 
Resolves open-telemetry#101
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Jul 29, 2022
@tigrannajaryan
Implement compression for WebSocket transport
cf14483 
Resolves open-telemetry#101
@tigrannajaryan tigrannajaryan changed the title Add test with WebSocket compression enabled Implement compression in WebSocket client Aug 2, 2022
@tigrannajaryan tigrannajaryan mentioned this issue Aug 2, 2022
Closed
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Aug 2, 2022
@tigrannajaryan
Implement compression for WebSocket client
06989b4 
Resolves open-telemetry#101
@tigrannajaryan tigrannajaryan mentioned this issue Aug 2, 2022
Merged
@tigrannajaryan tigrannajaryan removed the help wanted Extra attention is needed label Aug 2, 2022
@tigrannajaryan tigrannajaryan self-assigned this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement compression for WebSocket client tigrannajaryan/opamp-go
1 participant
@tigrannajaryan