Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the protos to another repository #133

Closed
jlegoff opened this issue Sep 22, 2022 · 1 comment · Fixed by #134
Closed

Move the protos to another repository #133

jlegoff opened this issue Sep 22, 2022 · 1 comment · Fixed by #134

Comments

@jlegoff
Copy link
Contributor

jlegoff commented Sep 22, 2022

As per our discussion in slack, the protos should be moved to another repository so that the java implementation can use them.
@tigrannajaryan
Copy link
Member

tigrannajaryan commented Sep 22, 2022 •
edited
Loading

I think we can move the proto files to a sub-directory in opamp-spec and consume opamp-spec as a submodule in this repo.

This is similar to what we do with OTLP protos in https://github.com/open-telemetry/opentelemetry-proto-go

We already have a gen-proto target in makefile. It will need to use the proto files from the submodule. Generated files should continue to be stored in this repo.

Ideally also want a github action that verifies that protos match the generated file.

This was referenced Sep 22, 2022
Closed
Merged
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Sep 22, 2022
@tigrannajaryan
Move proto files to opamp-spec repo
3a05d7d 
Contributes to open-telemetry/opamp-go#133

Now that we are adding OpAMP Java implementation the protos can no longer
live in opamp-go. We are moving the protos to the spec repo since it fits
this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in
the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions
from specification.md and instead link them directly to the proto files so
that we have a single source of truth.
@tigrannajaryan tigrannajaryan mentioned this issue Sep 22, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Sep 22, 2022
@tigrannajaryan
Move proto files to opamp-spec repo
164b4d0 
Contributes to open-telemetry/opamp-go#133

Now that we are adding OpAMP Java implementation the protos can no longer
live in opamp-go. We are moving the protos to the spec repo since it fits
this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in
the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions
from specification.md and instead link them directly to the proto files so
that we have a single source of truth.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Sep 22, 2022
@tigrannajaryan
Move proto files to opamp-spec repo
f97ed2f 
Contributes to open-telemetry/opamp-go#133

Now that we are adding OpAMP Java implementation the protos can no longer
live in opamp-go. We are moving the protos to the spec repo since it fits
this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in
the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions
from specification.md and instead link them directly to the proto files so
that we have a single source of truth.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Sep 22, 2022
@tigrannajaryan
Move proto files to opamp-spec repo
fb07a02 
Contributes to open-telemetry/opamp-go#133

Now that we are adding OpAMP Java implementation the protos can no longer
live in opamp-go. We are moving the protos to the spec repo since it fits
this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in
the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions
from specification.md and instead link them directly to the proto files so
that we have a single source of truth.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Sep 22, 2022
@tigrannajaryan
Move proto files to opamp-spec repo
32cd8a6 
Contributes to open-telemetry/opamp-go#133

Now that we are adding OpAMP Java implementation the protos can no longer
live in opamp-go. We are moving the protos to the spec repo since it fits
this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in
the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions
from specification.md and instead link them directly to the proto files so
that we have a single source of truth.
tigrannajaryan added a commit to open-telemetry/opamp-spec that referenced this issue Sep 22, 2022
@tigrannajaryan
Move proto files to opamp-spec repo (#126)
53241a7 
Contributes to open-telemetry/opamp-go#133

Now that we are adding OpAMP Java implementation the protos can no longer
live in opamp-go. We are moving the protos to the spec repo since it fits
this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in
the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions
from specification.md and instead link them directly to the proto files so
that we have a single source of truth.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Sep 22, 2022
@tigrannajaryan
Add opamp-spec as submodule to consume protos
6cf5e84 
Proto files were moved to opamp-spec. They are no longer necessary here.
We now consume protos from opamp-spec repo.

Resolves open-telemetry#133
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Sep 22, 2022
@tigrannajaryan
Add opamp-spec as submodule to consume protos
39b6e86 
Proto files were moved to opamp-spec. They are no longer necessary here.
We now consume protos from opamp-spec repo.

Resolves open-telemetry#133
@tigrannajaryan tigrannajaryan mentioned this issue Sep 22, 2022
Merged
tigrannajaryan added a commit that referenced this issue Sep 22, 2022
@tigrannajaryan
Add opamp-spec as submodule to consume protos (#134)
83a6659 
Proto files were moved to opamp-spec. They are no longer necessary here.
We now consume protos from opamp-spec repo.

Resolves #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add opamp-spec as submodule to consume protos tigrannajaryan/opamp-go
2 participants
@jlegoff @tigrannajaryan