Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement server #32

Closed
Tracked by #16
tigrannajaryan opened this issue Dec 6, 2021 · 1 comment
Closed
Tracked by #16

Implement server #32

tigrannajaryan opened this issue Dec 6, 2021 · 1 comment

Comments

@tigrannajaryan
Copy link
Member

Implement the OpAMPServer interface.
@tigrannajaryan tigrannajaryan mentioned this issue Dec 6, 2021
Closed
2 tasks
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation
dc02fab 
Contributes to open-telemetry#32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

TODO:
- Handle closing and waiting for existing connections.
- Decide what to do with OnDisconnect callback.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation
cd3e899 
Contributes to open-telemetry#32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

TODO:
- Handle closing and waiting for existing connections.
- Decide what to do with OnDisconnect callback.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation
3cc1919 
Contributes to open-telemetry#32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

TODO:
- Handle closing and waiting for existing connections.
- Decide what to do with OnDisconnect callback.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation
7917b13 
Contributes to open-telemetry#32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

TODO:
- Handle closing and waiting for existing connections.
- Wait for listening in Start().
- Decide what to do with OnDisconnect callback.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation
620990a 
Contributes to open-telemetry#32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

Also added ListenPath to server StartSettings since it is necessary
to implement the server.

TODO:
- Handle closing and waiting for existing connections.
- Wait for listening in Start().
- Decide what to do with OnDisconnect callback.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation
4e0281e 
Contributes to open-telemetry#32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

Also added ListenPath to server StartSettings since it is necessary
to implement the server.

TODO:
- Handle closing and waiting for existing connections.
- Wait for listening in Start().
- Decide what to do with OnDisconnect callback.
@tigrannajaryan tigrannajaryan mentioned this issue Dec 6, 2021
Merged
tigrannajaryan added a commit that referenced this issue Dec 6, 2021
@tigrannajaryan
Begin basic server implementation (#33)
1715144 
Contributes to #32

This implements the OpAMPServer interface and adds some basic tests
to verify the functionality.

Also added ListenPath to server StartSettings since it is necessary
to implement the server.

TODO:
- Handle closing and waiting for existing connections.
- Wait for listening in Start().
- Decide what to do with OnDisconnect callback.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 7, 2021
@tigrannajaryan
Wait in Start() until server starts listening
192a8ce 
This is a requirement of the OpAMPServer interface
which wasn't implemented initially. It should work
correcly now.

Contriubtes to open-telemetry#32
@tigrannajaryan tigrannajaryan mentioned this issue Dec 7, 2021
Merged
tigrannajaryan added a commit that referenced this issue Dec 7, 2021
@tigrannajaryan
Wait in Start() until server starts listening (#36)
4b29e3b 
This is a requirement of the OpAMPServer interface
which wasn't implemented initially. It should work
correcly now.

Contriubtes to #32
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue Dec 8, 2021
@tigrannajaryan
Wait in Start() until server starts listening (open-telemetry#36)
2c20371 
This is a requirement of the OpAMPServer interface
which wasn't implemented initially. It should work
correcly now.

Contriubtes to open-telemetry#32
@tigrannajaryan
Copy link
Member Author

Basic functionality is now implemented. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tigrannajaryan