Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup client agent description setting #47

Closed
tigrannajaryan opened this issue Dec 21, 2021 · 0 comments · Fixed by #74
Closed

Cleanup client agent description setting #47

tigrannajaryan opened this issue Dec 21, 2021 · 0 comments · Fixed by #74

Comments

@tigrannajaryan
Copy link
Member

It is currently possible to set agent description in StartSettings and via SetAgentDescription.

Do we need both? Can we eliminate one?
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue May 13, 2022
@tigrannajaryan
Eliminate StartSettings.AgentDescription
7957091 
We don't need 2 ways to set AgentDescription, it is confusing.
Now the only way is to call SetAgentDescription(), which must be
called before Start() and may be called after Start() too.

Resolves open-telemetry#47
@tigrannajaryan tigrannajaryan mentioned this issue May 13, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue May 13, 2022
@tigrannajaryan
Eliminate StartSettings.AgentDescription
30f7323 
We don't need 2 ways to set AgentDescription, it is confusing.
Now the only way is to call SetAgentDescription(), which must be
called before Start() and may be called after Start() too.

Resolves open-telemetry#47
tigrannajaryan added a commit that referenced this issue May 13, 2022
@tigrannajaryan
Eliminate StartSettings.AgentDescription (#74)
dfbe616 
We don't need 2 ways to set AgentDescription, it is confusing.
Now the only way is to call SetAgentDescription(), which must be
called before Start() and may be called after Start() too.

Resolves #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminate StartSettings.AgentDescription tigrannajaryan/opamp-go
1 participant
@tigrannajaryan