Restructure modules - phase 3 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
commented
Mar 13, 2024
| @@ -370,7 +372,9 @@ private void applyConfiguration() { | |||
| if (initializationEvents == InitializationEvents.NO_OP) { | |||
| initializationEvents = new SdkInitializationEvents(); | |||
| } | |||
| initializationEvents.recordConfiguration(config); | |||
| Map<String, String> configMap = new HashMap<>(); | |||
| // TODO: Convert config to map | |||
There was a problem hiding this comment.
I opened #277 to track this.
There was a problem hiding this comment.
I wish there could be a way to pass the config object without having to transform it into a map though, it feels awkward. But I guess we can leave it as is for now. I'll follow up on the ticket on this.
...rc/test/java/io/opentelemetry/android/instrumentation/activity/VisibleScreenTrackerTest.java
Outdated
Show resolved
Hide resolved
...tup/src/main/java/io/opentelemetry/android/instrumentation/startup/InitializationEvents.java
Show resolved
Hide resolved
android-agent/build.gradle.kts
Outdated
There was a problem hiding this comment.
Do you think we should add the fragment module too?
There was a problem hiding this comment.
It's used indirectly through the Activity instrumentation. If we want to change that, can we do it in a separate PR plz?
There was a problem hiding this comment.
Ah got it, that's fine then, I thought it was not being added. Cheers!
LikeTheSalad
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #267 and #269.
This migrates the subdirs in instrumentation to be their own instrumentation modules, as discussed previously.