Update dependency versions. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
commented
Apr 15, 2024
gradle/libs.versions.toml
Outdated
| @@ -1,6 +1,7 @@ | |||
| [versions] | |||
| opentelemetry = "1.37.0" | |||
| opentelemetry-alpha = "2.2.0-alpha" | |||
| opentelemetry-inst = "2.3.0" | |||
There was a problem hiding this comment.
I think it's clearer with inst in the name, to know when you have the instrumentation version (vs. core version).
There was a problem hiding this comment.
I like the idea of replacing alpha with something more meaningful. I would prefer to avoid abbreviations though, I know opentelemetry-instrumentation could be a lot, though the first time I saw inst, for some reason "instrumentation" wasn't the first word that came to my mind 😅
There was a problem hiding this comment.
Ok, fine, I'll spell out inst -> instrumentation...but I'm not going to change semconv. :)
marandaneto
reviewed
Apr 16, 2024
breedx-splk
commented
Apr 16, 2024
…' into update_gradle_wrapper_validation
LikeTheSalad
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instrumentation bom is not alpha, so this updates that while updating us to the latest. It also updates the gradle version wrapper to the latest name.