Skip to content

Commit

Permalink
Adding Resource to MetricRecord (#1209)
Browse files Browse the repository at this point in the history
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
  • Loading branch information
2 people authored and codeboten committed Oct 23, 2020
1 parent 6e3965b commit 56ffabd
Showing 1 changed file with 13 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ def test_shutdown(self):
def test_export(self):
with self._registry_register_patch:
record = MetricRecord(
self._test_metric, self._labels_key, SumAggregator(),
self._test_metric,
self._labels_key,
SumAggregator(),
get_meter_provider().resource,
)
exporter = PrometheusMetricsExporter()
result = exporter.export([record])
Expand All @@ -86,7 +89,9 @@ def test_min_max_sum_aggregator_to_prometheus(self):
aggregator.update(123)
aggregator.update(456)
aggregator.take_checkpoint()
record = MetricRecord(metric, key_labels, aggregator)
record = MetricRecord(
metric, key_labels, aggregator, get_meter_provider().resource
)
collector = CustomCollector("testprefix")
collector.add_metrics_data([record])
result_bytes = generate_latest(collector)
Expand All @@ -104,7 +109,9 @@ def test_counter_to_prometheus(self):
aggregator = SumAggregator()
aggregator.update(123)
aggregator.take_checkpoint()
record = MetricRecord(metric, key_labels, aggregator)
record = MetricRecord(
metric, key_labels, aggregator, get_meter_provider().resource
)
collector = CustomCollector("testprefix")
collector.add_metrics_data([record])

Expand Down Expand Up @@ -132,7 +139,9 @@ def test_invalid_metric(self):
)
labels = {"environment": "staging"}
key_labels = get_dict_as_key(labels)
record = MetricRecord(metric, key_labels, None)
record = MetricRecord(
metric, key_labels, None, get_meter_provider().resource
)
collector = CustomCollector("testprefix")
collector.add_metrics_data([record])
collector.collect()
Expand Down

0 comments on commit 56ffabd

Please sign in to comment.