Skip to content

Commit

Permalink
remove use of typeStr
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme committed Apr 27, 2023
1 parent 88a0221 commit 7a5b636
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
6 changes: 4 additions & 2 deletions extension/sigv4authextension/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import (
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/confmap/confmaptest"

"github.com/open-telemetry/opentelemetry-collector-contrib/extension/sigv4authextension/internal/metadata"
)

func TestLoadConfig(t *testing.T) {
Expand All @@ -36,7 +38,7 @@ func TestLoadConfig(t *testing.T) {
require.NoError(t, err)
factory := NewFactory()
cfg := factory.CreateDefaultConfig()
sub, err := cm.Sub(component.NewID(typeStr).String())
sub, err := cm.Sub(component.NewID(metadata.Type).String())
require.NoError(t, err)
require.NoError(t, component.UnmarshalConfig(sub, cfg))

Expand All @@ -58,7 +60,7 @@ func TestLoadConfigError(t *testing.T) {
require.NoError(t, err)
factory := NewFactory()
cfg := factory.CreateDefaultConfig()
sub, err := cm.Sub(component.NewIDWithName(typeStr, "missing_credentials").String())
sub, err := cm.Sub(component.NewIDWithName(metadata.Type, "missing_credentials").String())
require.NoError(t, err)
require.NoError(t, component.UnmarshalConfig(sub, cfg))
assert.Error(t, component.ValidateConfig(cfg))
Expand Down
7 changes: 1 addition & 6 deletions extension/sigv4authextension/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,9 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/sigv4authextension/internal/metadata"
)

const (
// The value of extension "type" in configuration.
typeStr = "sigv4auth"
)

// NewFactory creates a factory for the Sigv4 Authenticator extension.
func NewFactory() extension.Factory {
return extension.NewFactory(typeStr, createDefaultConfig, createExtension, metadata.Stability)
return extension.NewFactory(metadata.Type, createDefaultConfig, createExtension, metadata.Stability)
}

// createDefaultConfig() creates a Config struct with default values.
Expand Down

0 comments on commit 7a5b636

Please sign in to comment.