Revert "exporter/zipkin: Fix zipkin exporter translation bug (#1149)"

This reverts commit 855a7e1.
open-telemetry · Oct 23, 2020 · 875d5bf · 875d5bf
1 parent c35697e
commit 875d5bf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py b/exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
@@ -184,9 +184,9 @@ def _translate_to_zipkin(self, spans: Sequence[Span]):
                 ] = span.instrumentation_info.version
 
             if span.status is not None:
-                zipkin_span["tags"]["otel.status_code"] = str(
-                    span.status.canonical_code.value
-                )
+                zipkin_span["tags"][
+                    "otel.status_code"
+                ] = span.status.canonical_code.value
                 if span.status.description is not None:
                     zipkin_span["tags"][
                         "otel.status_description"

diff --git a/exporter/opentelemetry-exporter-zipkin/tests/test_zipkin_exporter.py b/exporter/opentelemetry-exporter-zipkin/tests/test_zipkin_exporter.py
@@ -217,7 +217,7 @@ def test_export(self):
                     "key_bool": "False",
                     "key_string": "hello_world",
                     "key_float": "111.22",
-                    "otel.status_code": "2",
+                    "otel.status_code": 2,
                     "otel.status_description": "Example description",
                 },
                 "annotations": [
@@ -239,7 +239,7 @@ def test_export(self):
                 "kind": None,
                 "tags": {
                     "key_resource": "some_resource",
-                    "otel.status_code": "0",
+                    "otel.status_code": 0,
                 },
                 "annotations": None,
             },
@@ -254,7 +254,7 @@ def test_export(self):
                 "tags": {
                     "key_string": "hello_world",
                     "key_resource": "some_resource",
-                    "otel.status_code": "0",
+                    "otel.status_code": 0,
                 },
                 "annotations": None,
             },
@@ -269,7 +269,7 @@ def test_export(self):
                 "tags": {
                     "otel.instrumentation_library.name": "name",
                     "otel.instrumentation_library.version": "version",
-                    "otel.status_code": "0",
+                    "otel.status_code": 0,
                 },
                 "annotations": None,
             },
@@ -335,7 +335,7 @@ def test_zero_padding(self):
                 "duration": duration // 10 ** 3,
                 "localEndpoint": local_endpoint,
                 "kind": None,
-                "tags": {"otel.status_code": "0"},
+                "tags": {"otel.status_code": 0},
                 "annotations": None,
                 "debug": True,
                 "parentId": "0aaaaaaaaaaaaaaa",