Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health endpoint to Splunk HEC exporter #16479

Closed
omrozowicz-splunk opened this issue Nov 25, 2022 · 3 comments
Closed

Add health endpoint to Splunk HEC exporter #16479

omrozowicz-splunk opened this issue Nov 25, 2022 · 3 comments
Labels
enhancement New feature or request exporter/splunkhec needs triage New item requiring triage

Comments

@omrozowicz-splunk
Copy link
Contributor

Component(s)

exporter/splunkhec

Is your feature request related to a problem? Please describe.

Splunk HEC has an API health endpoint /services/collector/health, which returns 200 if the service is up. Currently, we don't make use of that in the exporter, we only send a chunk of data and observe if it was successful or not.
Would be good to run one call to the health endpoint when the exporter starts, before we process the data.

Describe the solution you'd like

The /services/collector/health should be configurable (as there is an option to do that in Splunk HEC), and the GET request to that API would be inserted before pushLogData, pushMetricsData, pushTracesData, in sync.Once, so that the request would be done only once. If it fails, consumererror should be returned.

Describe alternatives you've considered

No response

Additional context

No response

@omrozowicz-splunk omrozowicz-splunk added enhancement New feature or request needs triage New item requiring triage labels Nov 25, 2022
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Jan 7, 2023

Is there any more work on this issue? Can it be closed at this time?

@omrozowicz-splunk
Copy link
Contributor Author

@atoulme no, no more work is required. It can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/splunkhec needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

2 participants