Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/translator/prometheusremotewrite] Implement Exponential Histogram downscaling #17565

Closed
kovrus opened this issue Jan 13, 2023 · 5 comments · Fixed by #24026
Closed

[pkg/translator/prometheusremotewrite] Implement Exponential Histogram downscaling #17565

kovrus opened this issue Jan 13, 2023 · 5 comments · Fixed by #24026
Assignees

Comments

@kovrus
Copy link
Member

kovrus commented Jan 13, 2023

Component(s)

pkg/translator/prometheusremotewrite

Is your feature request related to a problem? Please describe.

When converting the Exponential Histogram to Prometheus Native Histogram its data points will be dropped if their scale is not in the [-4, 8] range.

Describe the solution you'd like

Exponential Histogram data points should be downscaled to a scale accepted by Prometheus (range [-4,8]) if its scale is greater than 8.

Describe alternatives you've considered

Exponential Histogram data points can be dropped if their scales are greater than 8.

Additional context

See comments in open-telemetry/opentelemetry-specification#3079

@kovrus kovrus added enhancement New feature or request needs triage New item requiring triage labels Jan 13, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

  • pkg/translator/prometheusremotewrite: @Aneurysm9

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for pkg/translator/prometheusremotewrite: @Aneurysm9. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Mar 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@krajorama
Copy link
Contributor

I've started to work on this. I will not introduce configuration to select the cutoff for downscaling (8), but I'll keep the code generic that it can be introduced later as needed.

@kovrus
Copy link
Member Author

kovrus commented Jul 7, 2023

@krajorama thanks! I've assigned this issue to you.

jpkrohling added a commit that referenced this issue Jul 17, 2023
…prometheus (#24026)

**Description:** 

Implement down-scaling of exponential histograms to Prometheus native
histograms in Prometheus remote writer.
Configuration of down-scaling is TBD.

**Link to tracking Issue:**

Fixes: #17565 

**Testing:**

Unit tests.

**Documentation:**

TBD

---------

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Co-authored-by: Ruslan Kovalov <ruslan.kovalov@grafana.com>
Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants