Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export logs to Loki #1894

Closed
gramidt opened this issue Dec 23, 2020 · 6 comments
Closed

Export logs to Loki #1894

gramidt opened this issue Dec 23, 2020 · 6 comments
Labels
enhancement New feature or request priority:p2 Medium release:allowed-for-ga spec:logs

Comments

@gramidt
Copy link
Member

gramidt commented Dec 23, 2020 •
edited

Is your feature request related to a problem? Please describe.
I would like to send log data to Loki (https://grafana.com/docs/loki/latest/)

Describe the solution you'd like
Have an exporter that sends log data to Loki.

Additional context
A PR will soon be provided that accomplishes this request. The primary driver for Loki is that its design is similar to that of Cortex and reduces the cost of operating a logging solution at scale.

Progress

  1. Initial structure and documentation of exporter (✔️ Add Loki as a log exporter (first PR: overall structure) #1900 Added Loki exporter codeowner #1928 added Loki exporter dependabot entry #1929)
  2. Exporter implementation (✔️ lokiexporter: Implementation ( PR 2/3 ) #2262 lokiexporter: Remove dependency on https://github.com/grafana/loki, due to incompatible dep issues #2385 lokiexporter: Refactor #2385 to follow the current project conventions for third-party code #2389)
  3. Add exporter to binary
@gramidt gramidt changed the title Export OTLP logs to Loki Export logs to Loki Dec 24, 2020
@gramidt gramidt mentioned this issue Dec 24, 2020
Merged
This was referenced Jan 3, 2021
Merged
Merged
@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
@gramidt gramidt mentioned this issue Jan 6, 2021
Closed
@gramidt
Copy link
Member Author

gramidt commented Jan 11, 2021

Update: PR #1952 will be finished and ready for review this coming week.

@gramidt gramidt mentioned this issue Jan 11, 2021
Closed
@tomwilkie
Copy link

/cc @slim-bean can you take a look?

dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@vikrambe
1306:Migrate TailSamplingProcessor to new OTLP-based internal data mo…
1942ad2 
…del and add Composite Sampler (#1894)

Migrate Tail Sampling Processor to the new OTLP-based internal data model and add composite sampler

**Design Doc - Added support for composite policy in tailsampling processor. This would help in grouping sampling policies and rate limiting them. https://docs.google.com/document/d/10wpIv3TtXgOik05smHm3nYeBX48Bj76TCMxPy8e1NZw/edit#heading=h.ecy5l2puwtp4

**Link to tracking Issue:** 1306

**Testing:** Unit testing

**Documentation:** Refer open-telemetry/opentelemetry-collector#1306, https://docs.google.com/document/d/10wpIv3TtXgOik05smHm3nYeBX48Bj76TCMxPy8e1NZw/edit#heading=h.ecy5l2puwtp4
This was referenced Feb 1, 2021
Merged
Closed
Closed
@gramidt
Copy link
Member Author

gramidt commented Feb 7, 2021

@andrewhsu - Could you assign this to me?

@gramidt gramidt mentioned this issue Feb 12, 2021
Closed
6 tasks
@slim-bean
Copy link

Apologies @gramidt have not forgotten about this but haven't had a chance just yet to follow up!

@gramidt
Copy link
Member Author

gramidt commented Feb 18, 2021 •
edited

No worries at all, @slim-bean! I appreciate you taking the time to review and ensure that the implementation is the best it can be.

On a side note, I would love https://github.com/grafana/loki-client-go to have an official versioned release and assurance that it will be kept in sync, so that this implementation can use it for the generated protos and maybe eventually use the client pieces too. This would help reduce the dependencies used to the minimum.

This was referenced Feb 20, 2021
Merged
Closed
Closed
Merged
Merged
@gramidt
Copy link
Member Author

gramidt commented Feb 23, 2021

The exporter has been added to the binary. Other enhancements for the exporter exist as other GH issues. Closing this issue.

@gramidt gramidt closed this as completed Feb 23, 2021
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@hs0210 @MrAlias
Fix some golint issues (#1894)
97eea6c 
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:p2 Medium release:allowed-for-ga spec:logs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andrewhsu @tomwilkie @gramidt @slim-bean