Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lokiexporter] Implementation ( PR 2/3 ) #1952

Closed
wants to merge 1 commit into from
Closed

[Lokiexporter] Implementation ( PR 2/3 ) #1952

wants to merge 1 commit into from

Conversation

gramidt
Copy link
Member

@gramidt gramidt commented Jan 6, 2021

Description:
The implementation of the Loki exporter.

Link to tracking Issue:
#1894

Testing:
Unit Tests

Documentation:
Godoc and README

@project-bot project-bot bot added this to In progress in Collector Jan 6, 2021
@gramidt gramidt changed the title [lokiexporter] Implementation ( PR 2/3 ) [Lokiexporter] Implementation ( PR 2/3 ) Jan 6, 2021
@gramidt gramidt mentioned this pull request Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1952 (02d20b4) into master (ebd62bd) will increase coverage by 1.03%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1952      +/-   ##
==========================================
+ Coverage   89.15%   90.18%   +1.03%     
==========================================
  Files         393      396       +3     
  Lines       19329    19493     +164     
==========================================
+ Hits        17233    17580     +347     
+ Misses       1641     1448     -193     
- Partials      455      465      +10     
Flag Coverage Δ
integration 69.79% <ø> (?)
unit 88.97% <53.84%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/lokiexporter/loki.go 36.58% <34.21%> (-50.09%) ⬇️
exporter/lokiexporter/logdata_to_loki.go 50.00% <50.00%> (ø)
exporter/lokiexporter/config.go 73.91% <73.91%> (ø)
exporter/lokiexporter/factory.go 94.73% <100.00%> (-5.27%) ⬇️
internal/common/testing/container/container.go 73.68% <0.00%> (ø)
processor/groupbytraceprocessor/event.go 96.80% <0.00%> (+0.79%) ⬆️
receiver/prometheusexecreceiver/receiver.go 88.33% <0.00%> (+2.50%) ⬆️
receiver/jmxreceiver/receiver.go 94.80% <0.00%> (+16.88%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd62bd...81b826d. Read the comment docs.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 14, 2021
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jan 22, 2021
Collector automation moved this from In progress to Done Jan 22, 2021
@pmm-sumo
Copy link
Contributor

I think something might have gone off with auto-assigning the reviewers for this PR. Also, the community asks for this exporter. Perhaps it should be reopened @bogdandrutu @tigrannajaryan ?

@gramidt
Copy link
Member Author

gramidt commented Jan 29, 2021

@pmm-sumo - Yeah, I plan on re-opening this PR very soon. I ended up having to refocus on other tasks the past two weeks, but will come back to this either this coming weekend or next week.

@tigrannajaryan
Copy link
Member

Feel free to reopen. Not sure why it was not assigned to anyone. Was it a draft PR maybe?

@gramidt
Copy link
Member Author

gramidt commented Jan 29, 2021

@tigrannajaryan - Yes, this was a draft PR that was still a WIP.

@gramidt
Copy link
Member Author

gramidt commented Jan 29, 2021

@pmm-sumo - I also just responded in the Gitter channel letting Ferenc know I'll be finishing it in the near future. Thank you so much for bringing this to my attention!

@gramidt
Copy link
Member Author

gramidt commented Jan 29, 2021

@tigrannajaryan - I'm having trouble re-opening this PR. Any chance you are able to re-open it with your permissions?

@tigrannajaryan
Copy link
Member

@tigrannajaryan - I'm having trouble re-opening this PR. Any chance you are able to re-open it with your permissions?

@gramidt I can't either (not sure why). Please create a new PR.

@gramidt
Copy link
Member Author

gramidt commented Feb 1, 2021

Thank you for trying, @tigrannajaryan! I will create a new PR.

ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.5 to 2.1.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.5...v2.1.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants