Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[servicegraph] Check if virtual client nodes have orphan server spans #19764

Closed
mapno opened this issue Mar 17, 2023 · 3 comments
Closed

[servicegraph] Check if virtual client nodes have orphan server spans #19764

mapno opened this issue Mar 17, 2023 · 3 comments
Labels
connector/servicegraph

Comments

@mapno
Copy link
Contributor

mapno commented Mar 17, 2023

Component(s)

processor/servicegraph

Describe the issue you're reporting

Only create client virtual nodes when server spans are orphans. Otherwise, any server span without a match will create a virtual node.

Ref: #17350 (comment)
@mapno mapno added the needs triage New item requiring triage label Mar 17, 2023
@mapno mapno mentioned this issue Mar 17, 2023
Merged
@github-actions
Copy link
Contributor

Pinging code owners for connector/servicegraph: @jpkrohling @mapno. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Mar 17, 2023
@JaredTan95
Copy link
Member

finished by #19763
this issue can be closed.

@atoulme
Copy link
Contributor

atoulme commented Apr 14, 2023

Closing.

@atoulme atoulme closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connector/servicegraph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@atoulme @kovrus @JaredTan95 @mapno