[processor/servicegraph]add virtual node feature.

[JaredTan95]

Signed-off-by: Jared Tan jian.tan@daocloud.io

Description:
impl #17196

Link to tracking Issue:

Testing:

Documentation:

[runforesight]

Foresight Summary

    
Major Impacts

build-and-test duration(35 minutes 43 seconds) has decreased 30 minutes 40 seconds compared to main branch avg(1 hour 6 minutes 23 seconds).

View More Details

✅  tracegen workflow has finished in 1 minute 1 second (3 minutes 30 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

---

Job	Failed Steps	Tests
build-dev	-     🔗	N/A	See Details
publish-latest	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details

---

⭕  build-and-test-windows workflow has finished in 6 seconds (40 minutes 54 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
windows-unittest-matrix	-     🔗	N/A	See Details
windows-unittest	-     🔗	N/A	See Details

---

✅  telemetrygen workflow has finished in 1 minute (2 minutes 7 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
publish-stable	-     🔗	N/A	See Details
build-dev	-     🔗	N/A	See Details
publish-latest	-     🔗	N/A	See Details

---

✅  check-links workflow has finished in 1 minute 31 seconds (1 minute 4 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
changed files	-     🔗	N/A	See Details
check-links	-     🔗	N/A	See Details

---

✅  changelog workflow has finished in 2 minutes 11 seconds and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
changelog	-     🔗	N/A	See Details

---

✅  prometheus-compliance-tests workflow has finished in 3 minutes 19 seconds (5 minutes 27 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
prometheus-compliance-tests	-     🔗	✅ 21  ❌ 0  ⏭ 0    🔗	See Details

---

✅  load-tests workflow has finished in 7 minutes 19 seconds (9 minutes 34 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	-     🔗	✅ 3  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestIdleMode)	-     🔗	✅ 1  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile)	-     🔗	✅ 6  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs)	-     🔗	✅ 8  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs)	-     🔗	✅ 10  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS)	-     🔗	✅ 12  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestBallastMemory|TestLog10kDPS)	-     🔗	✅ 18  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details

---

✅  build-and-test workflow has finished in 35 minutes 43 seconds (30 minutes 40 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
unittest-matrix (1.20, extension)	-     🔗	✅ 537  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, extension)	-     🔗	✅ 537  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, internal)	-     🔗	✅ 561  ❌ 0  ⏭ 0    🔗	See Details
correctness-metrics	-     🔗	✅ 2  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, internal)	-     🔗	✅ 561  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, processor)	-     🔗	✅ 1532  ❌ 0  ⏭ 0    🔗	See Details
correctness-traces	-     🔗	✅ 17  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, processor)	-     🔗	✅ 1532  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, receiver-0)	-     🔗	✅ 2575  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, receiver-0)	-     🔗	✅ 2575  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, exporter)	-     🔗	✅ 2455  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, receiver-1)	-     🔗	✅ 1928  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, exporter)	-     🔗	✅ 2455  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, other)	-     🔗	✅ 4687  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, other)	-     🔗	✅ 4687  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, receiver-1)	-     🔗	✅ 1928  ❌ 0  ⏭ 0    🔗	See Details
integration-tests	-     🔗	✅ 55  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details
check-collector-module-version	-     🔗	N/A	See Details
check-codeowners	-     🔗	N/A	See Details
build-examples	-     🔗	N/A	See Details
checks	-     🔗	N/A	See Details
lint-matrix (receiver-0)	-     🔗	N/A	See Details
lint-matrix (receiver-1)	-     🔗	N/A	See Details
lint-matrix (processor)	-     🔗	N/A	See Details
lint-matrix (exporter)	-     🔗	N/A	See Details
lint-matrix (extension)	-     🔗	N/A	See Details
lint-matrix (internal)	-     🔗	N/A	See Details
lint-matrix (other)	-     🔗	N/A	See Details
lint	-     🔗	N/A	See Details
unittest (1.20)	-     🔗	N/A	See Details
unittest (1.19)	-     🔗	N/A	See Details
cross-compile (darwin, amd64)	-     🔗	N/A	See Details
cross-compile (darwin, arm64)	-     🔗	N/A	See Details
cross-compile (linux, 386)	-     🔗	N/A	See Details
cross-compile (linux, amd64)	-     🔗	N/A	See Details
cross-compile (linux, arm)	-     🔗	N/A	See Details
cross-compile (linux, arm64)	-     🔗	N/A	See Details
cross-compile (linux, ppc64le)	-     🔗	N/A	See Details
cross-compile (windows, 386)	-     🔗	N/A	See Details
cross-compile (windows, amd64)	-     🔗	N/A	See Details
build-package (deb)	-     🔗	N/A	See Details
build-package (rpm)	-     🔗	N/A	See Details
windows-msi	-     🔗	N/A	See Details
publish-check	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details
publish-dev	-     🔗	N/A	See Details

---

✅  e2e-tests workflow has finished in 11 minutes 36 seconds (4 minutes 19 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
kubernetes-test	-     🔗	N/A	See Details

---

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[JaredTan95]

comments for no stale

[jpkrohling]

@mapno, would you be able to review this one as well?

[mapno]

I like the idea, but I'd rather keep it from leaking into internal/store if possible. We can have it be part of p.onExpire, which is a practically unused function at the moment. Ie. when the edge expires, we check if it has peer attributes, and we aggregate the metrics if that's the case.

Also, this should be a configurable feature. Mainly b/c there aren't official semantic conventions that identify the type of requests we're trying to support.

[JaredTan95]

I like the idea, but I'd rather keep it from leaking into internal/store if possible. We can have it be part of p.onExpire, which is a practically unused function at the moment. Ie. when the edge expires, we check if it has peer attributes, and we aggregate the metrics if that's the case.

Also, this should be a configurable feature. Mainly b/c there aren't official semantic conventions that identify the type of requests we're trying to support.

@jpkrohling @mapno thx for your review, I polished those logical

[JaredTan95]

But a little confused, VerifyXXX in the test is not guaranteed to be called back every time.

[mapno]

Thanks for the PR. I think we're close, it needs to be simplified a bit. Also, docs in the README about this flag would be great.

[JaredTan95]

lint ci time out : https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4122369157/jobs/7119166768#step:9:43

[mapno]

I think this is making great progress. Thanks for the patience and for addressing my comments. Left a few more, many of them just of style.

[JaredTan95]

I think this is making great progress. Thanks for the patience and for addressing my comments. Left a few more, many of them just of style.

thx for your review, you helped me a lot something I didn't noticed.

[mapno]

Alright, just left two minor comments. Otherwise, this is good to go for me. Thanks for the work! I'll leave it to OTel maintainers to final approve and merge.

[JaredTan95]

we need to re-trigger the CI ?https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4160007985/jobs/7196621241#step:15:337

[djaglowski]

Please rebase. The failing test was removed in #18519.

[JaredTan95]

Please rebase. The failing test was removed in #18519.

ok