Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/opampsupervisor] Persist Collector instance ID #21073

Closed
evan-bradley opened this issue Apr 19, 2023 · 4 comments · Fixed by #32618
Closed

[cmd/opampsupervisor] Persist Collector instance ID #21073

evan-bradley opened this issue Apr 19, 2023 · 4 comments · Fixed by #32618
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed

Comments

@evan-bradley
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

The Supervisor should create Collector instance ID to set in the Collector's resource attributes, and should also persist this ID so that it stays the same across Supervisor restarts. For more, see the design document.

Describe the solution you'd like

Allow configuring where the Supervisor persists information according to the config schema defined in the design document and store the instance ID in this location.

Describe alternatives you've considered

No response

Additional context

No response
@evan-bradley evan-bradley added the enhancement New feature or request label Apr 19, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@mwear mwear removed the Stale label Jun 21, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Aug 21, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
@evan-bradley evan-bradley reopened this Oct 24, 2023
@evan-bradley evan-bradley added never stale Issues marked with this label will be never staled and automatically removed and removed Stale closed as inactive labels Oct 24, 2023
@BinaryFissionGames
Copy link
Contributor

I'll work on adding this

@BinaryFissionGames BinaryFissionGames mentioned this issue Apr 23, 2024
Merged
djaglowski pushed a commit that referenced this issue May 16, 2024
@BinaryFissionGames
[cmd/opampsupervisor]: Persist the instance ID between restarts (#32618)
125ff49 
**Description:** <Describe what has changed.>
* Adds the ability to persist the instance ID on disk and load it on
startup.

**Link to tracking Issue:** Closes #21073

**Testing:**
* Add unit tests for persistence functionality
* Add e2e tests for persistence (testing that initial id is persisted,
and that server specified ID is persisted)

**Documentation:** N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
No milestone
3 participants
@mwear @BinaryFissionGames @evan-bradley